Please give me some feedback

I'm not sure I understand what the change to the API is here. Doesn't the search API already return federated users and magazines?

Oddly enough no, not in the normal result items. Before my change it asserted, that the items can only be of ContentInterface and the OpenAPI schema lists these contents:

new OA\Schema(ref: new Model(type: EntryResponseDto::class)),
        new OA\Schema(ref: new Model(type: EntryCommentResponseDto::class)),
        new OA\Schema(ref: new Model(type: PostResponseDto::class)),
        new OA\Schema(ref: new Model(type: PostCommentResponseDto::class)),

In the API docs, it looks like there's an apActors property returned from /search, which can be either a user or a magazine. Then it looks like there's an apObjects property which can be a thread, thread comment, microblog, or microblog comment.

I'm obviously not looking at the code though, so maybe the API docs are incorrect?

They are correct about the items not containing users or magazines. But the content of the returned object is a bit weird. As far as I understood it from the code the items contain content which matched by text, apActors contain users and magazines fetched via searched handle or AP url and apObjects contain content fetched via AP url.

Honestly, I'm in favor to rework the whole search API to make it more consistent and easy to understand, but breaking an unversioned API is probably not the best idea.

Ah, gotcha. Well, I'm fine keeping it how it is or changing it. It would be nice if the Mbin API were versioned. Considering it's not in wide use (that I know of), you could just make the breaking change, and we can fix Interstellar to work with the change afterwards.

I changed the API to make it more consistent with other newer APIs we have. I still needed to keep one extra prop in the response for results of handle and url searches, as these are not paginated and so must be kept separately from items.