Prevent crashes during and after cleanup (cont'd)

jamesobutler · jcfr · commit 05f31f9d0cb8 · 2025-09-01T02:22:26.000-04:00
This is a follow-up to HEAD~3 ("Prevent crashes during and after cleanup") (cherry picked from commit commontk/PythonQt@8aa183b)
diff --git a/src/PythonQtObjectPtr.cpp b/src/PythonQtObjectPtr.cpp
@@ -172,7 +172,7 @@ PythonQtSafeObjectPtr::~PythonQtSafeObjectPtr()
 {
   if (_object) {
     PYTHONQT_GIL_SCOPE
-    Py_DECREF(_object);
+    if (_object && Py_IsInitialized()) Py_DECREF(_object);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ PythonQtSafeObjectPtr::~PythonQtSafeObjectPtr()`
`172`	`172`	`{`
`173`	`173`	`if (_object) {`
`174`	`174`	`PYTHONQT_GIL_SCOPE`
`175`		`- Py_DECREF(_object);`
	`175`	`+ if (_object && Py_IsInitialized()) Py_DECREF(_object);`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`