chore(PythonQtObjectPtr): Remove redundant nullptr checks

jcfr · jcfr · commit 2d59af7fee33 · 2025-09-01T17:56:01.000-04:00
Suggested-by: Uwe Siems &lt;uwe.siems@mevis.de&gt;
diff --git a/src/PythonQtObjectPtr.cpp b/src/PythonQtObjectPtr.cpp
@@ -109,7 +109,7 @@ PythonQtObjectPtr::PythonQtObjectPtr(PythonQtSafeObjectPtr &&p) :_object(p.takeO
 
 PythonQtObjectPtr::~PythonQtObjectPtr()
 {
-  if (_object && Py_IsInitialized()) Py_XDECREF(_object);
+  if (Py_IsInitialized()) Py_XDECREF(_object);
 }
 
 void PythonQtObjectPtr::setNewRef(PyObject* o)
@@ -172,7 +172,7 @@ PythonQtSafeObjectPtr::~PythonQtSafeObjectPtr()
 {
   if (_object) {
     PYTHONQT_GIL_SCOPE
-    if (_object && Py_IsInitialized()) Py_DECREF(_object);
+    if (Py_IsInitialized()) Py_DECREF(_object);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ PythonQtObjectPtr::PythonQtObjectPtr(PythonQtSafeObjectPtr &&p) :_object(p.takeO`
`109`	`109`
`110`	`110`	`PythonQtObjectPtr::~PythonQtObjectPtr()`
`111`	`111`	`{`
`112`		`- if (_object && Py_IsInitialized()) Py_XDECREF(_object);`
	`112`	`+ if (Py_IsInitialized()) Py_XDECREF(_object);`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`void PythonQtObjectPtr::setNewRef(PyObject* o)`
`@@ -172,7 +172,7 @@ PythonQtSafeObjectPtr::~PythonQtSafeObjectPtr()`
`172`	`172`	`{`
`173`	`173`	`if (_object) {`
`174`	`174`	`PYTHONQT_GIL_SCOPE`
`175`		`- if (_object && Py_IsInitialized()) Py_DECREF(_object);`
	`175`	`+ if (Py_IsInitialized()) Py_DECREF(_object);`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`