Better reference management pattern

iakov · mrbean-bremen · commit c43e264cc242 · 2024-04-02T13:55:04.000+02:00
diff --git a/src/PythonQt.cpp b/src/PythonQt.cpp
@@ -2137,8 +2137,9 @@ PyObject* PythonQtPrivate::packageByName(const char* name)
     v = PyImport_AddModule((_pythonQtModuleName + "." + name).constData());
     _packages.insert(name, v);
     // AddObject steals the reference, so increment it!
-    Py_INCREF(v);
-    PyModule_AddObject(_pythonQtModule, name, v);
+    if (PyModule_AddObject(_pythonQtModule, name, v) == 0) {
+      Py_INCREF(v);
+    }
   }
   return v;
 }

Original file line number	Diff line number	Diff line change
`@@ -2137,8 +2137,9 @@ PyObject* PythonQtPrivate::packageByName(const char* name)`
`2137`	`2137`	`v = PyImport_AddModule((_pythonQtModuleName + "." + name).constData());`
`2138`	`2138`	`_packages.insert(name, v);`
`2139`	`2139`	`// AddObject steals the reference, so increment it!`
`2140`		`- Py_INCREF(v);`
`2141`		`- PyModule_AddObject(_pythonQtModule, name, v);`
	`2140`	`+ if (PyModule_AddObject(_pythonQtModule, name, v) == 0) {`
	`2141`	`+ Py_INCREF(v);`
	`2142`	`+ }`
`2142`	`2143`	`}`
`2143`	`2144`	`return v;`
`2144`	`2145`	`}`