Check that externally defined operators are not added twice

Author: usiems

generator/abstractmetabuilder.cpp

@@ -315,7 +315,7 @@ void AbstractMetaBuilder::traverseStreamOperator(FunctionModelItem item)
 
                 setupFunctionDefaults(streamFunction, streamedClass);
 
-                streamedClass->addFunction(streamFunction);
+                streamedClass->addFunction(streamFunction, /*check_duplicates=*/true);
                 streamedClass->typeEntry()->addExtraInclude(streamClass->typeEntry()->include());
 
                 m_current_class = old_current_class;
@@ -354,7 +354,7 @@ void AbstractMetaBuilder::traverseArithmeticOperator(FunctionModelItem item)
 
       setupFunctionDefaults(streamFunction, aClass);
 
-      aClass->addFunction(streamFunction);
+      aClass->addFunction(streamFunction, /*check_duplicates=*/true);
       if (bClass) {
         aClass->typeEntry()->addExtraInclude(bClass->typeEntry()->include());
       }

generator/abstractmetalang.cpp

@@ -1094,10 +1094,20 @@ bool AbstractMetaClass::hasDefaultToStringFunction() const
     return false;
 }
 
-void AbstractMetaClass::addFunction(AbstractMetaFunction *function)
+void AbstractMetaClass::addFunction(AbstractMetaFunction *function, bool check_duplicates)
 {
     function->setOwnerClass(this);
 
+    if (check_duplicates) {
+        for (const auto f : m_functions) {
+            if (f->name() == function->name() &&
+                f->minimalSignature() == function->minimalSignature())
+            {
+                return;
+            }
+        }
+    }
+
     if (!function->isDestructor()) {
         m_functions << function;
         // seems like this is not needed and takes a lot of performance

generator/abstractmetalang.h

@@ -692,7 +692,7 @@ class AbstractMetaClass : public AbstractMetaAttributes
 
     AbstractMetaFunctionList functions() const { return m_functions; }
     void setFunctions(const AbstractMetaFunctionList &functions);
-    void addFunction(AbstractMetaFunction *function);
+    void addFunction(AbstractMetaFunction *function, bool check_duplicates = false);
     void removeFunction(AbstractMetaFunction* function);
     bool hasFunction(const AbstractMetaFunction *f) const;
     bool hasFunction(const QString &str) const;