fix: reset options when buffer is hidden

## Details

Issue: #209

Currently when a user leaves a buffer we render the buffer.

This works as expected when a user is say switching between multiple windows.

However if a user re-uses the current window for another buffer it will
have the window options applied as if it is rendered markdown, i.e. a
conceallevel of 3, which is unepected. This can also occur if a plugin
opens a buffer in the window via the `nvim_win_set_buf` API.

This occurs because at the time the update is triggered the buffer and
window are associated with each other, however due to the use of
vim.schedule when the update occurs this may not longer be the case.

To fix this add a check that the buffer is the one associated with the
window being updated. Include this in the `util.valid` logic so it will
be used at the time the update is triggered and at the time it is
actually ran.

Other minor changes:

- Remove `buf` field from `BufferState`
- Updated window related utility functions
- Remove wrapper functions where they are not needed, i.e. all the
  renderers will work out of the box no need to add one in each module

Author: MeanderingProgrammer

lua/render-markdown/core/buffer_state.lua

@@ -1,16 +1,13 @@
 ---@class render.md.BufferState
----@field private buf integer
 ---@field private timer uv_timer_t
 ---@field private running boolean
 ---@field private marks? render.md.Extmark[]
 local BufferState = {}
 BufferState.__index = BufferState
 
----@param buf integer
 ---@return render.md.BufferState
-function BufferState.new(buf)
+function BufferState.new()
     local self = setmetatable({}, BufferState)
-    self.buf = buf
     self.timer = (vim.uv or vim.loop).new_timer()
     self.running = false
     self.marks = nil

lua/render-markdown/core/context.lua

@@ -52,14 +52,14 @@ end
 ---@param offset integer
 ---@return render.md.Range
 function Context.compute_range(buf, win, offset)
-    local top = math.max(util.view(win).topline - 1 - offset, 0)
+    local top = math.max(util.win_view(win).topline - 1 - offset, 0)
 
     local bottom = top
     local lines = vim.api.nvim_buf_line_count(buf)
     local size = vim.api.nvim_win_get_height(win) + (2 * offset)
     while bottom < lines and size > 0 do
         bottom = bottom + 1
-        if util.visible(win, bottom) then
+        if util.win_visible(win, bottom) then
             size = size - 1
         end
     end
@@ -142,11 +142,7 @@ end
 ---@return integer
 function Context:get_width()
     if self.window_width == nil then
-        self.window_width = vim.api.nvim_win_get_width(self.win)
-        local window_info = vim.fn.getwininfo(self.win)
-        if #window_info == 1 then
-            self.window_width = self.window_width - window_info[1].textoff
-        end
+        self.window_width = vim.api.nvim_win_get_width(self.win) - util.win_textoff(self.win)
     end
     return self.window_width
 end

lua/render-markdown/core/list.lua

@@ -8,13 +8,13 @@ local util = require('render-markdown.core.util')
 local Marks = {}
 Marks.__index = Marks
 
----@param mode string
----@param ignore render.md.config.conceal.Ignore
+---@param mode? string
+---@param ignore? render.md.config.conceal.Ignore
 ---@return render.md.Marks
 function Marks.new(mode, ignore)
     local self = setmetatable({}, Marks)
-    self.mode = mode
-    self.ignore = ignore
+    self.mode = mode or util.mode()
+    self.ignore = ignore or {}
     self.marks = {}
     return self
 end
@@ -70,12 +70,7 @@ end
 ---@class render.md.ListHelper
 local M = {}
 
----@param mode? string
----@param ignore? render.md.config.conceal.Ignore
----@return render.md.Marks
-function M.new_marks(mode, ignore)
-    return Marks.new(mode or util.mode(), ignore or {})
-end
+M.new_marks = Marks.new
 
 ---@generic T
 ---@param values T[]

lua/render-markdown/core/ui.lua

@@ -24,7 +24,7 @@ local Cache = {
 function Cache.get(buf)
     local buffer_state = Cache.states[buf]
     if buffer_state == nil then
-        buffer_state = BufferState.new(buf)
+        buffer_state = BufferState.new()
         Cache.states[buf] = buffer_state
     end
     return buffer_state
@@ -144,13 +144,13 @@ function M.next_state(config, win, mode)
     if not state.enabled then
         return 'default'
     end
-    if util.get_win(win, 'diff') then
+    if not config:render(mode) then
         return 'default'
     end
-    if util.view(win).leftcol ~= 0 then
+    if util.get_win(win, 'diff') then
         return 'default'
     end
-    if not config:render(mode) then
+    if util.win_view(win).leftcol ~= 0 then
         return 'default'
     end
     return 'rendered'

lua/render-markdown/core/util.lua

@@ -32,7 +32,13 @@ end
 ---@param win integer
 ---@return boolean
 function M.valid(buf, win)
-    return vim.api.nvim_buf_is_valid(buf) and vim.api.nvim_win_is_valid(win)
+    if not vim.api.nvim_buf_is_valid(buf) then
+        return false
+    end
+    if not vim.api.nvim_win_is_valid(win) then
+        return false
+    end
+    return buf == vim.fn.winbufnr(win)
 end
 
 ---@return string
@@ -75,19 +81,26 @@ end
 
 ---@param win integer
 ---@return vim.fn.winsaveview.ret
-function M.view(win)
+function M.win_view(win)
     return vim.api.nvim_win_call(win, vim.fn.winsaveview)
 end
 
 ---@param win integer
 ---@param row integer
 ---@return boolean
-function M.visible(win, row)
+function M.win_visible(win, row)
     return vim.api.nvim_win_call(win, function()
         return vim.fn.foldclosed(row) == -1
     end)
 end
 
+---@param win integer
+---@return integer
+function M.win_textoff(win)
+    local infos = vim.fn.getwininfo(win)
+    return #infos == 1 and infos[1].textoff or 0
+end
+
 ---@param file string
 ---@return number
 function M.file_size_mb(file)

lua/render-markdown/debug/validator.lua

@@ -171,14 +171,7 @@ function Validator.new()
     return self
 end
 
----@param config table<string, any>
----@param nilable boolean
----@param key? string|string[]
----@param path? string
----@return render.md.debug.ValidatorSpec
-function Validator:spec(config, nilable, key, path)
-    return Spec.new(self, config, nilable, key, path)
-end
+Validator.spec = Spec.new
 
 ---@param suffix string
 ---@param config table<string, any>

lua/render-markdown/health.lua

@@ -4,7 +4,7 @@ local state = require('render-markdown.state')
 local M = {}
 
 ---@private
-M.version = '7.4.3'
+M.version = '7.4.4'
 
 function M.check()
     M.start('version')

lua/render-markdown/manager.lua

@@ -72,9 +72,7 @@ function M.attach(buf)
                 return
             end
             local event, win = args.event, vim.api.nvim_get_current_win()
-            if buf == vim.fn.winbufnr(win) then
-                ui.debounce_update(buf, win, event, vim.tbl_contains(change_events, event))
-            end
+            ui.debounce_update(buf, win, event, vim.tbl_contains(change_events, event))
         end,
     })
 end

lua/render-markdown/render/checkbox.lua

@@ -7,15 +7,6 @@ local str = require('render-markdown.core.str')
 local Render = setmetatable({}, Base)
 Render.__index = Render
 
----@param marks render.md.Marks
----@param config render.md.buffer.Config
----@param context render.md.Context
----@param info render.md.NodeInfo
----@return render.md.Renderer
-function Render:new(marks, config, context, info)
-    return Base.new(self, marks, config, context, info)
-end
-
 ---@return boolean
 function Render:setup()
     local checkbox = self.config.checkbox

lua/render-markdown/render/code.lua

@@ -24,15 +24,6 @@ local str = require('render-markdown.core.str')
 local Render = setmetatable({}, Base)
 Render.__index = Render
 
----@param marks render.md.Marks
----@param config render.md.buffer.Config
----@param context render.md.Context
----@param info render.md.NodeInfo
----@return render.md.Renderer
-function Render:new(marks, config, context, info)
-    return Base.new(self, marks, config, context, info)
-end
-
 ---@return boolean
 function Render:setup()
     self.code = self.config.code