Fix edge cases when hiding line graph previews

Switched hiding to be based on whether the time is within the visible range, which addresses an edge case when the sample is visible but is the last before the end of the range. This change also fixes an edge case where the selected time would be outside the visible range when unlocking the selection.

Author: jwbonner

src/hub/SelectionImpl.ts

@@ -246,6 +246,7 @@ export default class SelectionImpl implements Selection {
   unlock() {
     if (this.mode === SelectionMode.Locked) {
       let selectedTime = this.getSelectedTime();
+      this.applyTimelineScroll(0, 0, 0);
       this.setMode(SelectionMode.Static);
       this.staticTime = selectedTime !== null ? selectedTime : 0;
     }

src/hub/controllers/LineGraphController.ts

@@ -348,9 +348,15 @@ export default class LineGraphController implements TabController {
     filter: LineGraphFilter
   ): string | null {
     if (!(key in commandCache)) return null;
+    if (
+      time < window.selection.getTimelineRange()[0] ||
+      (time > window.selection.getTimelineRange()[1] && window.selection.getMode() !== SelectionMode.Locked)
+    ) {
+      return null;
+    }
     let command = commandCache[key];
     let index = command.timestamps.findLastIndex((sample) => sample <= time);
-    if (index === -1 || (index >= command.values.length - 1 && window.selection.getMode() !== SelectionMode.Locked)) {
+    if (index === -1) {
       return null;
     }
     let output = this.PREVIEW_FORMAT.format(command.values[index]);