Skip to content

Commit 2bee1df

Browse files
feat: add element deselection to various actions (#107)
Added calls to `deselectElement()` in multiple actions to ensure proper reset of selected elements before performing new operations, improving overall user interaction consistency. * Select Layer * New, Load, Save buttons * Undo Redo Closes #102 Co-authored-by: Tomás Grüner <[email protected]>
1 parent a440158 commit 2bee1df

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

src/index.ts

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import { Application, Assets } from "pixi.js";
22

3-
import { loadFromFile, saveToFile, urManager } from "./types/viewportManager";
3+
import {
4+
deselectElement,
5+
loadFromFile,
6+
saveToFile,
7+
urManager,
8+
} from "./types/viewportManager";
49
import { DataGraph } from "./types/graphs/datagraph";
510
import { Packet } from "./types/packet";
611
import { LeftBar } from "./graphics/left_bar";
@@ -89,10 +94,18 @@ async function loadAssets(otherPromises: Promise<void>[]) {
8994
const loadButton = document.getElementById("load-button");
9095
const saveButton = document.getElementById("save-button");
9196

92-
newButton.onclick = () => ctx.load(new DataGraph());
93-
saveButton.onclick = () => saveToFile(ctx);
94-
loadButton.onclick = () => loadFromFile(ctx);
95-
97+
newButton.onclick = () => {
98+
deselectElement();
99+
ctx.load(new DataGraph());
100+
};
101+
saveButton.onclick = () => {
102+
deselectElement();
103+
saveToFile(ctx);
104+
};
105+
loadButton.onclick = () => {
106+
deselectElement();
107+
loadFromFile(ctx);
108+
};
96109
// Undo button’s logic
97110
const undoButton = document.getElementById(
98111
"undo-button",
@@ -197,6 +210,7 @@ async function loadAssets(otherPromises: Promise<void>[]) {
197210
ctx.changeViewGraph(selectedLayer);
198211
// LeftBar is reset
199212
leftBar.setButtonsByLayer(selectedLayer);
213+
deselectElement();
200214
}
201215
};
202216

src/types/undo-redo/undoRedoManager.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { ViewGraph } from "../graphs/viewgraph";
2+
import { deselectElement } from "../viewportManager";
23
import { Move } from "./moves/move";
34

45
export class UndoRedoManager {
@@ -28,6 +29,7 @@ export class UndoRedoManager {
2829
this.notifyListeners();
2930
console.log(this.redoBuf);
3031
console.log(this.undoBuf);
32+
deselectElement();
3133
}
3234

3335
redo(viewgraph: ViewGraph) {
@@ -40,6 +42,7 @@ export class UndoRedoManager {
4042
this.notifyListeners();
4143
console.log(this.redoBuf);
4244
console.log(this.undoBuf);
45+
deselectElement();
4346
}
4447

4548
canUndo(): boolean {

0 commit comments

Comments
 (0)