look for ways to replace `afterRender`

[MelSumner]

right now, this addon uses afterRender- see if there is a way to do this so we don't have to use afterRender

[mansona]

When we discussed this the other day I said "something something octane, something something modifiers" because I really didn't know what I was talking about but I knew there was something in Octane that is perfect for this exact use case.

I did a bit of digging and I found it 🎉 essentially what we need to do is to use the did-insert element modifier on the div with class a11y-modal: https://octane-guides-preview.emberjs.com/release/components/glimmer-components-dom/#toc_calling-methods-on-first-render

The reason why this works like magic is that the did-insert modifier will only fire when {{#if isModalVisible}} becomes true.

Now it does raise a question of if we can make this work on older versions of Ember but I guess there will be some sort of polyfill that will allow us to make this addon work with modifiers and the consuming ember app would be none the wiser.

Let me know if this is a good enough explanation and if not I'll try to make it a bit clearer 👍

[MelSumner]

This makes sense- thanks for the tip!