Refactor to use Outcome

Author: MelbourneDeveloper

.editorconfig

@@ -12,7 +12,6 @@ dotnet_analyzer_diagnostic.category-Globalization.severity = error
 dotnet_analyzer_diagnostic.category-Documentation.severity = error
 dotnet_analyzer_diagnostic.category-Readability.severity = error
 dotnet_analyzer_diagnostic.category-Ordering.severity = error
-dotnet_analyzer_diagnostic.category-StyleCop.CSharp.OrderingRules.severity = none
 
 # Nullability
 # CS8602: Dereference of a possibly null reference.
@@ -41,7 +40,6 @@ dotnet_diagnostic.CA2000.severity = error
 dotnet_diagnostic.CA2201.severity = error
 dotnet_diagnostic.CS1591.severity = error
 dotnet_diagnostic.IDE0022.severity = error
-dotnet_diagnostic.CA1054.severity = error
 dotnet_diagnostic.CS8600.severity = error
 dotnet_diagnostic.CS8601.severity = error
 dotnet_diagnostic.CS8603.severity = error
@@ -373,9 +371,15 @@ dotnet_diagnostic.SA1400.severity = none
 dotnet_diagnostic.SA1114.severity = none
 dotnet_diagnostic.SA1118.severity = none
 dotnet_diagnostic.SA1649.severity = none
+dotnet_diagnostic.CA1054.severity = none
 
+dotnet_diagnostic.SA1200.severity = none
 
 
+# TODO: these are nice. Put back
+dotnet_diagnostic.SA1201.severity = none
+dotnet_diagnostic.SA1202.severity = none
+dotnet_diagnostic.SA1204.severity = none
 
 
 

RestClient.Net.OpenApiGenerator.Cli/Program.cs

@@ -6,6 +6,14 @@
     Outcome.HttpError<string>
 >;
 using ExceptionErrorString = Outcome.HttpError<string>.ExceptionError;
+using GeneratorError = Outcome.Result<
+    RestClient.Net.OpenApiGenerator.GeneratorResult,
+    string
+>.Error<RestClient.Net.OpenApiGenerator.GeneratorResult, string>;
+using GeneratorOk = Outcome.Result<RestClient.Net.OpenApiGenerator.GeneratorResult, string>.Ok<
+    RestClient.Net.OpenApiGenerator.GeneratorResult,
+    string
+>;
 using OkString = Outcome.Result<string, Outcome.HttpError<string>>.Ok<
     string,
     Outcome.HttpError<string>
@@ -186,29 +194,34 @@ await response.Content.ReadAsStringAsync(ct).ConfigureAwait(false),
     Console.WriteLine($"Downloaded {openApiSpec.Length} characters\n");
     Console.WriteLine("Generating C# code from OpenAPI spec...");
 
-    var generatorResult = OpenApiCodeGenerator.Generate(
+    var result = OpenApiCodeGenerator.Generate(
         openApiSpec,
         @namespace: config.Namespace,
         className: config.ClassName,
         outputPath: config.OutputPath,
         baseUrlOverride: config.BaseUrl
     );
 
-    Console.WriteLine(
-        $"Generated {generatorResult.ExtensionMethodsCode.Length} "
-            + "characters of extension methods"
-    );
-    Console.WriteLine($"Generated {generatorResult.ModelsCode.Length} " + "characters of models");
-
-    if (generatorResult.ExtensionMethodsCode.StartsWith("//", StringComparison.Ordinal))
+#pragma warning disable IDE0010
+    switch (result)
+#pragma warning restore IDE0010
     {
-        Console.WriteLine("\nError in generated code:");
-        Console.WriteLine(generatorResult.ExtensionMethodsCode);
-        return;
+        case GeneratorOk(var generatorResult):
+            Console.WriteLine(
+                $"Generated {generatorResult.ExtensionMethodsCode.Length} "
+                    + "characters of extension methods"
+            );
+            Console.WriteLine(
+                $"Generated {generatorResult.ModelsCode.Length} " + "characters of models"
+            );
+            Console.WriteLine($"\nSaved files to: {config.OutputPath}");
+            Console.WriteLine("\nGeneration completed successfully!");
+            break;
+        case GeneratorError(var error):
+            Console.WriteLine("\nCode generation failed:");
+            Console.WriteLine(error);
+            break;
     }
-
-    Console.WriteLine($"\nSaved files to: {config.OutputPath}");
-    Console.WriteLine("\nGeneration completed successfully!");
 }
 
 static string HandleDownloadError(string message)