All tests pass exception for .NET Framework

Author: MelbourneDeveloper

src/RestClient.Net.Abstractions/MissingHeaderException.cs

@@ -0,0 +1,15 @@
+using System;
+
+namespace RestClient.Net
+{
+    public class MissingHeaderException : Exception
+    {
+        public bool IsRequest { get; }
+
+        public MissingHeaderException(
+            string message,
+            bool isRequest,
+            Exception innerException) :
+            base(message, innerException) => IsRequest = isRequest;
+    }
+}

src/RestClient.Net.UnitTests/MainUnitTests.cs

@@ -288,6 +288,12 @@ public MainUnitTests()
         #region Tests
 
         #region External Api Tests
+
+#if !NET7_0_OR_GREATER
+
+        //TODO: Enable this for .NET 7 and up when the bugs get fixed
+
+
         [TestMethod]
         public async Task TestHead()
         {
@@ -309,6 +315,7 @@ public async Task TestHead()
 
             Assert.AreEqual(GoogleHeadHeaders[CacheControlHeaderName], response.Headers[CacheControlHeaderName].Single());
         }
+#endif
 
 #if !NET45
 
@@ -617,10 +624,13 @@ public async Task TestUpdate(HttpRequestMethod httpRequestMethod)
 #endif
         }
 
+#if !NET7_0_OR_GREATER
+
+        //TODO: Enable this for .NET 7 and up when the bugs get fixed
+
         [TestMethod]
         public async Task TestConsoleLogging()
         {
-            //var logger = new ConsoleLogger();
             using var client = new Client(
                 new NewtonsoftSerializationAdapter(),
                 baseUrl: JsonPlaceholderBaseUri,
@@ -633,6 +643,27 @@ public async Task TestConsoleLogging()
             Assert.AreEqual(101, response.Body?.Id);
             Assert.AreEqual(201, response.StatusCode);
         }
+#else
+        /// <summary>
+        /// This relates to this issue: https://github.com/dotnet/runtime/issues/81506
+        /// This should eventually get fixed but even if it doesn't this proves that RC Net at least
+        /// throws a meaningful exception
+        /// </summary>
+        [TestMethod]
+        public async Task TestDotNet7ErrorHandlingNoRequestHeader()
+        {
+            using var client = new Client(
+                new NewtonsoftSerializationAdapter(),
+                baseUrl: JsonPlaceholderBaseUri,
+                createHttpClient: GetCreateHttpClient(),
+                logger: consoleLoggerFactory.CreateLogger<Client>());
+
+            var missingHeaderException = await Assert.ThrowsExceptionAsync<MissingHeaderException>(async () =>
+            await client.PostAsync<PostUserResponse, UserPost>(_userRequestBody, JsonPlaceholderPostsSlug));
+
+            Assert.AreEqual("The media type header is missing. The request is missing the Content-Type header", missingHeaderException.Message);
+        }
+#endif
 
         [TestMethod]
         public async Task TestGetWithXmlSerialization()

src/RestClient.Net/Client.cs

@@ -262,6 +262,11 @@ public async Task<Response<TResponseBody>> SendAsync<TResponseBody, TRequestBody
                 logger.LogError(tce, Messages.ErrorTaskCancelled, request);
                 throw;
             }
+            catch (MissingHeaderException mhe)
+            {
+                logger.LogError(mhe, mhe.Message, request);
+                throw;
+            }
             catch (Exception ex)
             {
                 var exception = new SendException(Messages.ErrorSendException, request, ex);

src/RestClient.Net/DefaultSendHttpRequestMessage.cs

@@ -29,11 +29,31 @@ public async Task<HttpResponseMessage> SendHttpRequestMessage<TRequestBody>(
 
                 logger.LogTrace(Messages.InfoAttemptingToSend, request);
 
-                var httpResponseMessage = await httpClient.SendAsync(httpRequestMessage, request.CancellationToken).ConfigureAwait(false);
 
-                logger.LogInformation(Messages.InfoSendReturnedNoException);
+                try
+                {
+                    var httpResponseMessage = await httpClient.SendAsync(httpRequestMessage, request.CancellationToken).ConfigureAwait(false);
 
-                return httpResponseMessage;
+                    logger.LogInformation(Messages.InfoSendReturnedNoException);
+
+                    return httpResponseMessage;
+
+                }
+                catch (ArgumentException aex)
+                {
+                    if (aex.Message == "The value cannot be null or empty. (Parameter 'mediaType')")
+                    {
+                        var isRequest = httpRequestMessage.Content?.Headers.ContentType == null;
+                        var errorTypePart = isRequest ? $"The request is missing the {HeadersExtensions.ContentTypeHeaderName} header" :
+                            $"The request has the {HeadersExtensions.ContentTypeHeaderName} header so perhaps the response doesn't include it";
+                        throw
+                            new MissingHeaderException(
+                                $"The media type header is missing. {errorTypePart}",
+                                isRequest,
+                                aex); ;
+                    }
+                    throw;
+                }
             }
             catch (OperationCanceledException oce)
             {