chore: Dropped support for Python 3.8 (#196)

Author: edgarrmondragon

.github/workflows/ci_workflow.yml

@@ -23,16 +23,16 @@ on:
     - tox.ini
   workflow_dispatch:
 
+env:
+  FORCE_COLOR: 1
+
 jobs:
   pytest:
-    runs-on: ubuntu-latest
-    env:
-      GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:
         python-version:
-        - "3.8"
         - "3.9"
         - "3.10"
         - "3.11"

.pre-commit-config.yaml

@@ -32,3 +32,10 @@ repos:
     exclude: 'tests'
     additional_dependencies:
     - types-pytz==2022.7.1.2
+
+- repo: https://github.com/python-jsonschema/check-jsonschema
+  rev: 0.33.0
+  hooks:
+  - id: check-dependabot
+  - id: check-github-workflows
+  - id: check-meltano

meltano.yml

@@ -21,11 +21,11 @@ plugins:
   loaders:
   - name: target-csv
     namespace: target_csv
-    executable: ./target-csv.sh
+    pip_url: -e .
     capabilities:
-    - state
-    - catalog
-    - discover
+    - about
+    - stream-maps
+    - schema-flattening
     settings:
     - name: output_path
       kind: string

poetry.lock

@@ -16,7 +16,6 @@ classifiers = [
     "Intended Audience :: Developers",
     "License :: OSI Approved :: Apache Software License",
     "Operating System :: OS Independent",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -41,7 +40,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.ruff]
 line-length = 88
-target-version = "py38"
+target-version = "py39"
 
 [tool.ruff.lint]
 ignore = [
@@ -53,8 +52,14 @@ select = [
     "D",    # pydocstyle
     "E",    # pycodestyle (error)
     "F",    # pyflakes
-    "W",    # pycodestyle (warning)
+    "FA",   # flake8-future-annotations
+    "FURB", # refurb
+    "PERF", # Perflint
+    "UP",   # pyupgrade
     "S",    # flake8-bandit
+    "SIM",  # flake8-simplify
+    "TC",   # flake8-type-checking
+    "W",    # pycodestyle (warning)
 ]
 
 [tool.ruff.lint.flake8-annotations]

pyproject.toml

@@ -4,8 +4,10 @@
 
 import csv  # noqa: D100
 import tempfile
-from pathlib import Path
-from typing import Any
+from typing import Any, TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from pathlib import Path
 
 
 def write_csv(

target-csv.sh

@@ -7,28 +7,30 @@
 import sys
 import warnings
 from pathlib import Path
-from typing import Any, Dict, List, Optional
+from typing import Any, TYPE_CHECKING
 
 import pytz
-from singer_sdk import Target
 from singer_sdk.sinks import BatchSink
 
 from target_csv.serialization import write_batch, write_header
 
+if TYPE_CHECKING:
+    from singer_sdk import Target
+
 
 class CSVSink(BatchSink):
     """CSV target sink class."""
 
-    max_size = sys.maxsize  # We want all records in one batch
+    MAX_SIZE_DEFAULT = sys.maxsize
 
     def __init__(  # noqa: D107
         self,
         target: Target,
         stream_name: str,
-        schema: Dict,
-        key_properties: Optional[List[str]],
+        schema: dict,
+        key_properties: list[str] | None,
     ) -> None:
-        self._timestamp_time: Optional[datetime.datetime] = None
+        self._timestamp_time: datetime.datetime | None = None
         super().__init__(target, stream_name, schema, key_properties)
 
     @property
@@ -41,7 +43,7 @@ def timestamp_time(self) -> datetime.datetime:  # noqa: D102
         return self._timestamp_time
 
     @property
-    def filepath_replacement_map(self) -> Dict[str, str]:  # noqa: D102
+    def filepath_replacement_map(self) -> dict[str, str]:  # noqa: D102
         return {
             "stream_name": self.stream_name,
             "datestamp": self.timestamp_time.strftime(self.config["datestamp_format"]),
@@ -113,7 +115,7 @@ def process_batch(self, context: dict) -> None:
             self.logger.warning("No values in %s records collection.", self.stream_name)
             context["records"] = []
 
-        records: List[Dict[str, Any]] = context["records"]
+        records: list[dict[str, Any]] = context["records"]
         if "record_sort_property_name" in self.config:
             sort_property_name = self.config["record_sort_property_name"]
             records = sorted(records, key=lambda x: x[sort_property_name])

target_csv/serialization.py

@@ -1,22 +1,23 @@
 """Tests standard target features using the built-in SDK tests library."""
 
-from pathlib import Path
-import sys
-from typing import Any, Dict
+from __future__ import annotations
+
+from typing import Any, TYPE_CHECKING
 
 from singer_sdk.testing import get_target_test_class
 from singer_sdk.testing.suites import TestSuite
 from singer_sdk.testing.templates import TargetFileTestTemplate
 
-from . import data_files
 from target_csv.target import TargetCSV
 
-if sys.version_info >= (3, 9):
-    from importlib.resources import files
-else:
-    from importlib_resources import files
+from . import data_files
+
+from importlib.resources import files
+
+if TYPE_CHECKING:
+    from importlib.abc import Traversable
 
-SAMPLE_CONFIG: Dict[str, Any] = {
+SAMPLE_CONFIG: dict[str, Any] = {
     "escape_character": "\\",
 }
 
@@ -25,7 +26,7 @@ class MultipleStreamsTest(TargetFileTestTemplate):
     name = "users_and_employees"
 
     @property
-    def singer_filepath(self) -> Path:
+    def singer_filepath(self) -> Traversable:
         return files(data_files) / f"{self.name}.singer"
 
 

target_csv/sinks.py

@@ -1,13 +1,15 @@
 """CSV-related tests."""
 
+from __future__ import annotations
+
 from pathlib import Path
-from typing import Any, Dict, List, Tuple
+from typing import Any
 
 import pytest
 
 from target_csv.serialization import read_csv, write_batch, write_header
 
-SAMPLE_DATASETS: List[Tuple[Dict, List[Dict[str, Any]]]] = [
+SAMPLE_DATASETS: list[tuple[dict, list[dict[str, Any]]]] = [
     (
         # JSON Schema
         {
@@ -59,7 +61,7 @@ def output_filepath(output_dir) -> Path:
 
 
 @pytest.fixture
-def test_file_paths(output_dir) -> List[Path]:
+def test_file_paths(output_dir) -> list[Path]:
     paths = []
     for dir in range(4):
         path = Path(output_dir / f"test-dir-{dir}/csv-test-output-{dir}.csv")
@@ -90,6 +92,6 @@ def test_csv_roundtrip(output_filepath) -> None:
         write_batch(filepath=output_filepath, records=records, keys=keys)
         read_records = read_csv(filepath=output_filepath)
         for orig_record, new_record in zip(records, read_records):
-            for key in orig_record.keys():
+            for key in orig_record:
                 # Note: Results are stringified during serialization
                 assert str(orig_record[key]) == new_record[key]