Skip to content

Commit 2012dd1

Browse files
authored
fix: GeneralTextMemory._embed_one_sentence Argument Error (#76)
* fix: GeneralTextMemory._embed_one_sentence Argument Error * fix: fix unittest
1 parent c90f241 commit 2012dd1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/memos/memories/textual/general.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def drop(
202202

203203
def _embed_one_sentence(self, sentence: str) -> list[float]:
204204
"""Embed a single sentence."""
205-
return self.embedder.embed(sentence)[0]
205+
return self.embedder.embed([sentence])[0]
206206

207207

208208
EXTRACTION_PROMPT_PART_1 = f"""You are a memory extractor. Your task is to extract memories from the given messages.

tests/memories/textual/test_general.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def test_embed_one_sentence(self):
9898

9999
embedding = self.memory._embed_one_sentence(sentence)
100100

101-
self.mock_embedder.embed.assert_called_once_with(sentence)
101+
self.mock_embedder.embed.assert_called_once_with([sentence])
102102
self.assertEqual(embedding, expected_embedding)
103103

104104
def test_extract(self):
@@ -206,7 +206,7 @@ def test_update_memory(self):
206206
self.memory.update(memory_id_to_update, new_memory_dict)
207207

208208
self.mock_embedder.embed.assert_called_once_with(
209-
"This is the updated memory content via dict."
209+
["This is the updated memory content via dict."]
210210
)
211211

212212
args, _ = self.mock_vector_db.update.call_args
@@ -271,7 +271,7 @@ def test_search_memories(self):
271271

272272
search_results = self.memory.search(query, top_k)
273273

274-
self.mock_embedder.embed.assert_called_once_with(query)
274+
self.mock_embedder.embed.assert_called_once_with([query])
275275
self.mock_vector_db.search.assert_called_once_with(query_embedding, top_k)
276276

277277
self.assertEqual(len(search_results), top_k)

0 commit comments

Comments
 (0)