Skip to content

Commit 4e2d87f

Browse files
whipser030黑布林CaralHsifridayL
authored
fix: delete special charactors (#724)
* update reader and search strategy * set strategy reader and search config * fix install problem * fix * fix test * turn off graph recall * turn off graph recall * turn off graph recall * fix Searcher input bug * fix Searcher * fix Search * fix bug * adjust strategy reader * adjust strategy reader * adjust search config input * reformat code * re pr * format repair * fix time issue * develop feedback process * feedback handler configuration * upgrade feedback using * add threshold * update prompt * update prompt * fix handler * add feedback scheduler * add handler change node update * add handler change node update * add handler change node update * add handler change node update * fix interface input * add chunk and ratio filter * update stopwords * fix messages queue * add seach_by_keywords_LIKE * add doc filter * add retrieve query * add retrieve queies * patch info filter * add log and make embedding safety net * add log and make embedding safety net * deduplicate add objects * use _add_memories_parallel * delete Special characters * delete Special characters --------- Co-authored-by: 黑布林 <[email protected]> Co-authored-by: CaralHsi <[email protected]> Co-authored-by: chunyu li <[email protected]>
1 parent b1efa60 commit 4e2d87f

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/memos/mem_feedback/feedback.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import concurrent.futures
22
import difflib
33
import json
4+
import re
45

56
from datetime import datetime
67
from typing import TYPE_CHECKING, Any
@@ -493,7 +494,7 @@ def _info_comparison(self, memory: TextualMemoryItem, _info: dict, include_keys:
493494
record = []
494495
for key in include_keys:
495496
info_v = _info.get(key)
496-
mem_v = memory.metadata.info.get(key, None)
497+
mem_v = memory.metadata.info.get(key, None) if memory.metadata.info else None
497498
record.append(info_v == mem_v)
498499
return all(record)
499500

@@ -554,7 +555,8 @@ def _get_llm_response(self, prompt: str, dsl: bool = True) -> dict:
554555
response_text = self.llm.generate(messages, temperature=0.3, timeout=60)
555556
if dsl:
556557
response_text = response_text.replace("```", "").replace("json", "")
557-
response_json = json.loads(response_text)
558+
cleaned_text = re.sub(r"[\x00-\x08\x0B\x0C\x0E-\x1F\x7F]", "", response_text)
559+
response_json = json.loads(cleaned_text)
558560
else:
559561
return response_text
560562
except Exception as e:
@@ -620,7 +622,7 @@ def correct_item(data):
620622
dehallu_res = [correct_item(item) for item in operations]
621623
dehalluded_operations = [item for item in dehallu_res if item]
622624

623-
# deduplicate add objects
625+
# c add objects
624626
add_texts = []
625627
llm_operations = []
626628
for item in dehalluded_operations:
@@ -631,6 +633,9 @@ def correct_item(data):
631633
add_texts.append(item["text"])
632634
elif item["operation"].lower() == "update":
633635
llm_operations.append(item)
636+
logger.info(
637+
f"[Feedback Core: deduplicate add] {len(dehalluded_operations)} -> {len(llm_operations)} memories"
638+
)
634639

635640
# Update takes precedence over add
636641
has_update = any(item.get("operation").lower() == "update" for item in llm_operations)

0 commit comments

Comments
 (0)