fix: add feedback change to preference (#771)

* update reader and search strategy

* set strategy reader and search config

* fix install problem

* fix

* fix test

* turn off graph recall

* turn off graph recall

* turn off graph recall

* fix Searcher input bug

* fix Searcher

* fix Search

* fix bug

* adjust strategy reader

* adjust strategy reader

* adjust search config input

* reformat code

* re pr

* format repair

* fix time issue

* develop feedback process

* feedback handler configuration

* upgrade feedback using

* add threshold

* update prompt

* update prompt

* fix handler

* add feedback scheduler

* add handler change node update

* add handler change node update

* add handler change node update

* add handler change node update

* fix interface input

* add chunk and ratio filter

* update stopwords

* fix messages queue

* add seach_by_keywords_LIKE

* add doc filter

* add retrieve query

* add retrieve queies

* patch info filter

* add log and make embedding safety net

* add log and make embedding safety net

* deduplicate add objects

* use _add_memories_parallel

* delete Special characters

* delete Special characters

* delete Special characters

* delete Special characters

* add source_doc_id

* add source_doc_id

* add reranker in init com..

* fix circle import

* add feedback judgement

* add feedback judgement

* add pref feedback

* add pref feedback

---------

Co-authored-by: 黑布林 <[email protected]>
Co-authored-by: CaralHsi <[email protected]>
Co-authored-by: chunyu li <[email protected]>

Author: 4 people

src/memos/api/handlers/component_init.py

@@ -308,6 +308,7 @@ def init_server() -> dict[str, Any]:
         mem_reader=mem_reader,
         searcher=searcher,
         reranker=feedback_reranker,
+        pref_mem=pref_mem,
     )
 
     # Initialize Scheduler

src/memos/mem_feedback/feedback.py

@@ -4,6 +4,7 @@
 from memos.llms.factory import AzureLLM, OllamaLLM, OpenAILLM
 from memos.mem_feedback.feedback import MemFeedback
 from memos.mem_reader.simple_struct import SimpleStructMemReader
+from memos.memories.textual.simple_preference import SimplePreferenceTextMemory
 from memos.memories.textual.tree_text_memory.organize.manager import MemoryManager
 from memos.memories.textual.tree_text_memory.retrieve.retrieve_utils import StopwordManager
 from memos.memories.textual.tree_text_memory.retrieve.searcher import Searcher
@@ -23,6 +24,7 @@ def __init__(
         mem_reader: SimpleStructMemReader,
         searcher: Searcher,
         reranker: BaseReranker,
+        pref_mem: SimplePreferenceTextMemory,
     ):
         self.llm = llm
         self.embedder = embedder
@@ -31,5 +33,6 @@ def __init__(
         self.mem_reader = mem_reader
         self.searcher = searcher
         self.stopword_manager = StopwordManager
+        self.pref_mem = pref_mem
         self.reranker = reranker
         self.DB_IDX_READY = False

src/memos/mem_feedback/simple_feedback.py

@@ -48,8 +48,11 @@ def calculate_similarity(text1: str, text2: str) -> float:
     similarity = calculate_similarity(old_text, new_text)
     change_ratio = 1 - similarity
 
+    if change_ratio == float(0):
+        return False
+
     if old_len < 200:
-        return change_ratio < 0.5
+        return change_ratio < 0.7
     else:
         return change_ratio < 0.2
 

src/memos/mem_feedback/utils.py

@@ -418,6 +418,7 @@ def init_components() -> dict[str, Any]:
         mem_reader=mem_reader,
         searcher=searcher,
         reranker=feedback_reranker,
+        pref_mem=pref_mem,
     )
     # Return all components as a dictionary for easy access and extension
     return {"naive_mem_cube": naive_mem_cube, "feedback_server": feedback_server}

src/memos/mem_scheduler/general_modules/init_components_for_scheduler.py

@@ -87,6 +87,9 @@ def search(
         Returns:
             list[TextualMemoryItem]: List of matching memories.
         """
+        if not isinstance(search_filter, dict):
+            search_filter = {}
+        search_filter.update({"status": "activated"})
         logger.info(f"search_filter for preference memory: {search_filter}")
         return self.retriever.retrieve(query, top_k, info, search_filter)
 

src/memos/memories/textual/preference.py

@@ -61,6 +61,9 @@ def search(
         Returns:
             list[TextualMemoryItem]: List of matching memories.
         """
+        if not isinstance(search_filter, dict):
+            search_filter = {}
+        search_filter.update({"status": "activated"})
         return self.retriever.retrieve(query, top_k, info, search_filter)
 
     def add(self, memories: list[TextualMemoryItem | dict[str, Any]]) -> list[str]: