Skip to content

Commit 70bfa65

Browse files
committed
restore type/visibility
1 parent 3238dbf commit 70bfa65

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

examples/core_memories/general_textual_memory.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
{
3636
"memory": "I'm a RUCer, I'm happy.",
3737
"metadata": {
38-
"title": "happy RUCer",
38+
"key": "happy RUCer",
3939
"source": "conversation",
4040
"tags": ["happy"],
4141
"updated_at": "2025-05-19T00:00:00",
@@ -44,7 +44,7 @@
4444
{
4545
"memory": "MemOS is awesome!",
4646
"metadata": {
47-
"title": "MemOS",
47+
"key": "MemOS",
4848
"source": "conversation",
4949
"tags": ["awesome"],
5050
"updated_at": "2025-05-19T00:00:00",
@@ -71,7 +71,7 @@
7171
"id": example_id,
7272
"memory": "User is Chinese.",
7373
"metadata": {
74-
"title": "User Nationality",
74+
"key": "User Nationality",
7575
"source": "conversation",
7676
"tags": ["Nationality"],
7777
"updated_at": "2025-05-18T00:00:00",
@@ -98,7 +98,7 @@
9898
"id": example_id,
9999
"memory": "User is Canadian.",
100100
"metadata": {
101-
"title": "User Nationality",
101+
"key": "User Nationality",
102102
"source": "conversation",
103103
"tags": ["Nationality"],
104104
"updated_at": "2025-05-19T00:00:00",

src/memos/memories/textual/general.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def extract(self, messages: MessageList) -> list[TextualMemoryItem]:
6666
TextualMemoryItem(
6767
memory=memory_dict["value"],
6868
metadata={
69-
"title": memory_dict["key"],
69+
"key": memory_dict["key"],
7070
"source": "conversation",
7171
"tags": memory_dict["tags"],
7272
"updated_at": datetime.now().isoformat(),

src/memos/memories/textual/item.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ class TextualMemoryMetadata(BaseModel):
2727
default="activated",
2828
description="The status of the memory, e.g., 'activated', 'archived', 'deleted'.",
2929
)
30-
title: str | None = Field(default=None)
30+
type: str | None = Field(default=None)
31+
key: str | None = Field(default=None, description="Memory key or title.")
3132
confidence: float | None = Field(
3233
default=None,
3334
description="A numeric score (float between 0 and 100) indicating how certain you are about the accuracy or reliability of the memory.",
@@ -39,6 +40,9 @@ class TextualMemoryMetadata(BaseModel):
3940
default=None,
4041
description='A list of keywords or thematic labels associated with the memory for categorization or retrieval, e.g., `["travel", "health", "project-x"]`.',
4142
)
43+
visibility: Literal["private", "public", "session"] | None = Field(
44+
default=None, description="e.g., 'private', 'public', 'session'"
45+
)
4246
updated_at: str | None = Field(
4347
default_factory=lambda: datetime.now().isoformat(),
4448
description="The timestamp of the last modification to the memory. Useful for tracking memory freshness or change history. Format: ISO 8601.",
@@ -58,7 +62,6 @@ class TreeNodeTextualMemoryMetadata(TextualMemoryMetadata):
5862
memory_type: Literal["WorkingMemory", "LongTermMemory", "UserMemory"] = Field(
5963
default="WorkingMemory", description="Memory lifecycle type."
6064
)
61-
key: str | None = Field(default=None, description="Memory key or title.")
6265
sources: list[str] | None = Field(
6366
default=None, description="Multiple origins of the memory (e.g., URLs, notes)."
6467
)

tests/memories/textual/test_general.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@ def test_extract(self):
117117
self.assertEqual(len(result), 1)
118118
self.assertIsInstance(result[0], TextualMemoryItem)
119119
self.assertEqual(result[0].memory, "Hello")
120-
self.assertEqual(result[0].metadata.title, "greeting")
120+
self.assertEqual(result[0].metadata.key, "greeting")
121121

122122
def test_add_memories(self):
123123
"""Test adding memories."""
124124
memories_to_add = [
125125
{
126126
"memory": "I'm a RUCer, I'm happy.",
127127
"metadata": {
128-
"title": "happy RUCer",
128+
"key": "happy RUCer",
129129
"source": "conversation",
130130
"tags": ["happy"],
131131
"updated_at": "2025-05-19T00:00:00",
@@ -134,7 +134,7 @@ def test_add_memories(self):
134134
{
135135
"memory": "MemOS is awesome!",
136136
"metadata": {
137-
"title": "MemOS",
137+
"key": "MemOS",
138138
"source": "conversation",
139139
"tags": ["awesome"],
140140
"updated_at": "2025-05-19T00:00:00",
@@ -154,7 +154,7 @@ def test_update_memory(self):
154154
"id": memory_id_to_update,
155155
"memory": "This is the updated memory content via dict.",
156156
"metadata": {
157-
"title": "MemOS",
157+
"key": "MemOS",
158158
"source": "conversation",
159159
"tags": ["awesome"],
160160
"updated_at": "2025-05-19T00:00:00",
@@ -178,7 +178,7 @@ def test_update_memory(self):
178178

179179
memory_dict = updated_data_to_db.payload
180180
self.assertEqual(memory_dict["memory"], "This is the updated memory content via dict.")
181-
self.assertEqual(memory_dict["metadata"]["title"], "MemOS")
181+
self.assertEqual(memory_dict["metadata"]["key"], "MemOS")
182182
self.assertEqual(memory_dict["metadata"]["source"], "conversation")
183183

184184
def test_search_memories(self):

0 commit comments

Comments
 (0)