Skip to content

Commit 779275a

Browse files
committed
fix bugs: filter logging of retriever module in mem scheduler
1 parent b3e0e01 commit 779275a

File tree

2 files changed

+2
-29
lines changed

2 files changed

+2
-29
lines changed

src/memos/mem_scheduler/modules/retriever.py

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -136,32 +136,12 @@ def filter_similar_memories(
136136
f"Kept: '{text_memories[kept_idx][:100]}...' | "
137137
f"Removed: '{text_memories[current_idx][:100]}...'"
138138
)
139+
logger.info(removal_reasons)
139140
break
140141

141142
if not is_duplicate:
142143
to_keep.append(current_idx)
143144

144-
# Step 4: Log filtering results
145-
# Log individual removal reasons
146-
for idx, reason in removal_reasons.items():
147-
logging.info(f"Removed memory #{idx}: {reason}")
148-
149-
# Log summary statistics
150-
removed_count = len(original_memories) - len(kept_indices)
151-
removal_percentage = (removed_count / len(original_memories)) * 100
152-
153-
logging.info(
154-
f"Memory filtering complete. "
155-
f"Original: {len(original_memories)} | "
156-
f"Kept: {len(kept_indices)} | "
157-
f"Removed: {removed_count} ({removal_percentage:.1f}%)"
158-
)
159-
160-
# Log some examples of kept memories
161-
sample_size = min(3, len(kept_indices))
162-
for i in range(sample_size):
163-
logging.debug(f"Sample kept memory #{i + 1}: '{original_memories[kept_indices[i]][:200]}...'")
164-
165145
# Return filtered memories
166146
return [text_memories[i] for i in sorted(to_keep)]
167147

tests/mem_scheduler/test_retriever.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ def setUp(self):
5353

5454
# Mock logging to verify messages
5555
self.logging_patch = patch('logging.info')
56-
self.mock_logging = self.logging_patch.start()
5756

5857
def tearDown(self):
5958
"""Clean up patches."""
@@ -63,7 +62,6 @@ def test_filter_similar_memories_empty_input(self):
6362
"""Test filter_similar_memories with empty input list."""
6463
result = self.retriever.filter_similar_memories([])
6564
self.assertEqual(result, [])
66-
self.mock_logging.assert_called_with("Received empty memories list - nothing to filter")
6765

6866
def test_filter_similar_memories_no_duplicates(self):
6967
"""Test filter_similar_memories with no duplicate memories."""
@@ -87,12 +85,10 @@ def test_filter_similar_memories_with_duplicates(self):
8785
"This is a memory about DOGS and CATS" # Near duplicate with different case
8886
]
8987

90-
result = self.retriever.filter_similar_memories(memories, similarity_threshold=0.8)
88+
result = self.retriever.filter_similar_memories(memories, similarity_threshold=0.75)
9189
self.assertLess(len(result), len(memories))
9290
self.assertIn("This is a completely different memory", result)
9391

94-
# Verify logging was called for removed items
95-
self.assertGreater(self.mock_logging.call_count, 0)
9692

9793
def test_filter_similar_memories_error_handling(self):
9894
"""Test filter_similar_memories error handling."""
@@ -134,9 +130,6 @@ def test_filter_too_short_memories_with_short_ones(self):
134130
self.assertNotIn("Too short", result)
135131
self.assertNotIn("Nope", result)
136132

137-
# Verify logging was called for removed items
138-
self.mock_logging.assert_called_once()
139-
140133
def test_filter_too_short_memories_edge_case(self):
141134
"""Test filter_too_short_memories with edge case length."""
142135
memories = [

0 commit comments

Comments
 (0)