Skip to content

Commit 7f40968

Browse files
authored
hotfix bug in pref init (#502)
## Description <!-- Please include a summary of the changes below; Fill in the issue number that this PR addresses (if applicable); Fill in the related MemOS-Docs repository issue or PR link (if applicable); Mention the person who will review this PR (if you know who it is); Replace (summary), (issue), (docs-issue-or-pr-link), and (reviewer) with the appropriate information. 请在下方填写更改的摘要; 填写此 PR 解决的问题编号(如果适用); 填写相关的 MemOS-Docs 仓库 issue 或 PR 链接(如果适用); 提及将审查此 PR 的人(如果您知道是谁); 替换 (summary)、(issue)、(docs-issue-or-pr-link) 和 (reviewer) 为适当的信息。 --> Summary: (summary) Fix: #(issue) Docs Issue/PR: (docs-issue-or-pr-link) Reviewer: @(reviewer) ## Checklist: - [ ] I have performed a self-review of my own code | 我已自行检查了自己的代码 - [ ] I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释 - [ ] I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常 - [ ] I have created related documentation issue/PR in [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) (if applicable) | 我已在 [MemOS-Docs](https://github.com/MemTensor/MemOS-Docs) 中创建了相关的文档 issue/PR(如果适用) - [ ] I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用) - [ ] I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人
2 parents d505a93 + 8a93add commit 7f40968

File tree

4 files changed

+47
-28
lines changed

4 files changed

+47
-28
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ Designed for **AI companions, role-playing NPCs, and multi-agent systems**, MemO
5353
</div>
5454

5555

56-
Get Free API: [Try API](https://memos-dashboard.openmem.net/quickstart/?source=github)
57-
56+
Get Free API: [Try API](https://memos-dashboard.openmem.net/quickstart/?source=github)
57+
5858

5959
---
6060

evaluation/.env-example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,3 @@ MEMU_API_KEY="mu_xxx"
2121
SUPERMEMORY_API_KEY="sm_xxx"
2222
MEMOBASE_API_KEY="xxx"
2323
MEMOBASE_PROJECT_URL="http://***.***.***.***:8019"
24-

src/memos/api/routers/server_router.py

Lines changed: 33 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -187,32 +187,48 @@ def init_server():
187187

188188
# Create component instances
189189
graph_db = GraphStoreFactory.from_config(graph_db_config)
190-
vector_db = VecDBFactory.from_config(vector_db_config)
190+
vector_db = (
191+
VecDBFactory.from_config(vector_db_config)
192+
if os.getenv("ENABLE_PREFERENCE_MEMORY", "false").lower() == "true"
193+
else None
194+
)
191195
llm = LLMFactory.from_config(llm_config)
192196
embedder = EmbedderFactory.from_config(embedder_config)
193197
mem_reader = MemReaderFactory.from_config(mem_reader_config)
194198
reranker = RerankerFactory.from_config(reranker_config)
195199
internet_retriever = InternetRetrieverFactory.from_config(
196200
internet_retriever_config, embedder=embedder
197201
)
198-
pref_extractor = ExtractorFactory.from_config(
199-
config_factory=pref_extractor_config,
200-
llm_provider=llm,
201-
embedder=embedder,
202-
vector_db=vector_db,
202+
pref_extractor = (
203+
ExtractorFactory.from_config(
204+
config_factory=pref_extractor_config,
205+
llm_provider=llm,
206+
embedder=embedder,
207+
vector_db=vector_db,
208+
)
209+
if os.getenv("ENABLE_PREFERENCE_MEMORY", "false").lower() == "true"
210+
else None
203211
)
204-
pref_adder = AdderFactory.from_config(
205-
config_factory=pref_adder_config,
206-
llm_provider=llm,
207-
embedder=embedder,
208-
vector_db=vector_db,
212+
pref_adder = (
213+
AdderFactory.from_config(
214+
config_factory=pref_adder_config,
215+
llm_provider=llm,
216+
embedder=embedder,
217+
vector_db=vector_db,
218+
)
219+
if os.getenv("ENABLE_PREFERENCE_MEMORY", "false").lower() == "true"
220+
else None
209221
)
210-
pref_retriever = RetrieverFactory.from_config(
211-
config_factory=pref_retriever_config,
212-
llm_provider=llm,
213-
embedder=embedder,
214-
reranker=reranker,
215-
vector_db=vector_db,
222+
pref_retriever = (
223+
RetrieverFactory.from_config(
224+
config_factory=pref_retriever_config,
225+
llm_provider=llm,
226+
embedder=embedder,
227+
reranker=reranker,
228+
vector_db=vector_db,
229+
)
230+
if os.getenv("ENABLE_PREFERENCE_MEMORY", "false").lower() == "true"
231+
else None
216232
)
217233

218234
# Initialize memory manager

src/memos/mem_cube/navie.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,18 @@ def __init__(
5858
)
5959
self._act_mem: BaseActMemory | None = None
6060
self._para_mem: BaseParaMemory | None = None
61-
self._pref_mem: BaseTextMemory | None = SimplePreferenceTextMemory(
62-
extractor_llm=llm,
63-
vector_db=vector_db,
64-
embedder=embedder,
65-
reranker=reranker,
66-
extractor=pref_extractor,
67-
adder=pref_adder,
68-
retriever=pref_retriever,
61+
self._pref_mem: BaseTextMemory | None = (
62+
SimplePreferenceTextMemory(
63+
extractor_llm=llm,
64+
vector_db=vector_db,
65+
embedder=embedder,
66+
reranker=reranker,
67+
extractor=pref_extractor,
68+
adder=pref_adder,
69+
retriever=pref_retriever,
70+
)
71+
if os.getenv("ENABLE_PREFERENCE_MEMORY", "false").lower() == "true"
72+
else None
6973
)
7074

7175
def load(

0 commit comments

Comments
 (0)