Skip to content

Commit 9833254

Browse files
authored
feat(scheduler): Unify web log submission checks and add debug logs (#610)
Co-authored-by: [email protected] <>
1 parent 8cc4199 commit 9833254

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

src/memos/mem_scheduler/general_scheduler.py

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -595,12 +595,8 @@ def _mem_feedback_message_consumer(self, messages: list[ScheduleMessageItem]) ->
595595
f"Successfully processed feedback for user_id={user_id}, mem_cube_id={mem_cube_id}"
596596
)
597597

598-
should_send_log = (
599-
self.rabbitmq_config is not None
600-
and hasattr(self.rabbitmq_config, "exchange_type")
601-
and self.rabbitmq_config.exchange_type == "direct"
602-
)
603-
if should_send_log:
598+
is_cloud_env = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
599+
if is_cloud_env:
604600
record = feedback_result.get("record") if isinstance(feedback_result, dict) else {}
605601
add_records = record.get("add") if isinstance(record, dict) else []
606602
update_records = record.get("update") if isinstance(record, dict) else []
@@ -714,6 +710,11 @@ def _extract_fields(mem_item):
714710
task_id,
715711
stack_info=True,
716712
)
713+
else:
714+
logger.info(
715+
"Skipping web log for feedback. Not in a cloud environment (is_cloud_env=%s)",
716+
is_cloud_env,
717+
)
717718

718719
except Exception as e:
719720
logger.error(f"Error processing feedbackMemory message: {e}", exc_info=True)
@@ -1314,12 +1315,10 @@ def process_message(message: ScheduleMessageItem):
13141315

13151316
# Create and submit log for web display
13161317
# Only send logs if RabbitMQ is configured with direct exchange (cloud service scenario)
1317-
should_send_log = (
1318-
self.rabbitmq_config is not None
1319-
and hasattr(self.rabbitmq_config, "exchange_type")
1320-
and self.rabbitmq_config.exchange_type == "direct"
1318+
is_cloud_env = (
1319+
os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME") == "memos-memory-change"
13211320
)
1322-
if pref_ids and should_send_log:
1321+
if pref_ids and is_cloud_env:
13231322
pref_content = []
13241323
pref_meta = []
13251324
for i, pref_mem_item in enumerate(pref_memories):
@@ -1355,6 +1354,12 @@ def process_message(message: ScheduleMessageItem):
13551354
)
13561355
event.task_id = message.task_id
13571356
self._submit_web_logs([event])
1357+
else:
1358+
logger.info(
1359+
"Skipping web log for pref_add. pref_ids_count=%s is_cloud_env=%s",
1360+
len(pref_ids) if pref_ids else 0,
1361+
is_cloud_env,
1362+
)
13581363

13591364
except Exception as e:
13601365
logger.error(f"Error processing pref_add message: {e}", exc_info=True)

0 commit comments

Comments
 (0)