Skip to content

Commit ef68fb4

Browse files
committed
fix: test bug in tree_task_goal_parser
1 parent 7b111ca commit ef68fb4

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/memos/memories/textual/tree_text_memory/retrieve/task_goal_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _parse_response(self, response: str) -> ParsedTaskGoal:
8181
Parse LLM JSON output safely.
8282
"""
8383
try:
84-
response = response.replace("```", "").replace("json", "")
84+
response = response.replace("```", "").replace("json", "").strip()
8585
response_json = eval(response)
8686
return ParsedTaskGoal(
8787
memories=response_json.get("memories", []),

tests/memories/textual/test_tree_task_goal_parser.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ def generate(self, messages):
1818

1919

2020
def test_parse_fast_returns_expected():
21-
parser = TaskGoalParser(mode="fast")
22-
result = parser.parse("Tell me about cats")
21+
parser = TaskGoalParser()
22+
result = parser.parse("Tell me about cats", mode="fast")
2323

2424
assert isinstance(result, ParsedTaskGoal)
2525
assert result.memories == ["Tell me about cats"]
@@ -30,9 +30,9 @@ def test_parse_fast_returns_expected():
3030

3131
def test_parse_fine_calls_llm_and_parses():
3232
mock_llm = MockLLM()
33-
parser = TaskGoalParser(llm=mock_llm, mode="fine")
33+
parser = TaskGoalParser(llm=mock_llm)
3434

35-
result = parser.parse("Tell me about cats")
35+
result = parser.parse("Tell me about cats", mode="fine")
3636
assert isinstance(result, ParsedTaskGoal)
3737
assert result.memories == ["Cats are cute"]
3838
assert "cats" in result.keys
@@ -41,7 +41,7 @@ def test_parse_fine_calls_llm_and_parses():
4141

4242

4343
def test_parse_response_invalid_json():
44-
parser = TaskGoalParser(llm=MockLLM(), mode="fine")
44+
parser = TaskGoalParser(llm=MockLLM())
4545

4646
bad_response = "not a valid json"
4747
with pytest.raises(ValueError) as e:
@@ -50,14 +50,14 @@ def test_parse_response_invalid_json():
5050

5151

5252
def test_parse_fine_raises_without_llm():
53-
parser = TaskGoalParser(llm=None, mode="fine")
53+
parser = TaskGoalParser(llm=None)
5454
with pytest.raises(ValueError) as e:
55-
parser.parse("Hello")
55+
parser.parse("Hello", mode="fine")
5656
assert "LLM not provided" in str(e.value)
5757

5858

5959
def test_parse_raises_on_unknown_mode():
60-
parser = TaskGoalParser(mode="unknown")
60+
parser = TaskGoalParser()
6161
with pytest.raises(ValueError) as e:
62-
parser.parse("Hi")
62+
parser.parse("Hi", mode="unknown")
6363
assert "Unknown mode" in str(e.value)

0 commit comments

Comments
 (0)