Skip to content

fix: [PrefEval Evaluation]search CLI script does not propagate --lib / --version arguments #764

@Cream-yj

Description

@Cream-yj

Pre-submission checklist | 提交前检查

  • I have searched existing issues and this hasn't been mentioned before | 我已搜索现有问题,确认此问题尚未被提及
  • I have read the project documentation and confirmed this issue doesn't already exist | 我已阅读项目文档并确认此问题尚未存在
  • This issue is specific to MemOS and not a general software issue | 该问题是针对 MemOS 的,而不是一般软件问题

Bug Description | 问题描述

When running the ./scripts/run_prefeval_eval.sh command via the provided shell script, the --lib and --version flags are not forwarded to the search part Python CLI.
As a result, the script silently falls back to the default local memos backend instead of using the specified remote MemOS API.

How to Reproduce | 如何重现

1.set LIB=memos-api-online
2. run ./scripts/run_prefeval_eval.sh
3. see error: Error searching memory for line 990 (user_id: xxx): HTTPConnectionPool(host='127.0.0.1', port=8001): Max retries exceeded with url: /product/search (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x73f668427e90>: Failed to establish a new connection: [Errno 111] Connection refused'))
4. an empty folder will be created based on the default --lib and --version

Environment | 环境信息

  • python 3.11.14
  • MemoryOS 1.1.3

Additional Context | 其他信息

Suggested Fix:
Ensure that --lib and --version are explicitly forwarded in the shell script when calling the underlying Python CLI.

in the run_prefeval_eval.sh, line 107, add --lib and --version will be OK:

python $LIB_SCRIPT search \
    --input $IDS_FILE \
    --output $SEARCH_FILE \
    --top-k $TOP_K \
    --max-workers $WORKERS \
    --lib $LIB \
    --version $VERSION

Willingness to Implement | 实现意愿

  • I'm willing to implement this myself | 我愿意自己解决
  • I would like someone else to implement this | 我希望其他人来解决

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpendingPending items to be addressed | 待解决事项。

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions