fix(quality): remove unused imports and fix pixi environment config

MementoRC · MementoRC · commit 07927a9c367c · 2026-01-01T10:07:06.000-06:00
- Remove 79 unused imports (F401) across 40 test files via ruff --fix - Move semgrep to separate Python 3.11 environment (incompatible with 3.12) - Update requires-python from >=3.8 to >=3.11 (matches actual usage) - Add ruff configuration with target-version py311 - Add per-file-ignores for F403/F405 in conftest.py (pytest fixtures) - Remove conflicting [tool.pytest.benchmark] section - Clean up uv.lock and other untracked pip artifacts Quality gates: - Lint: PASS (ruff check --select=F,E9) - All critical violations resolved 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: MementoRC (https://github.com/MementoRC)
diff --git a/pyproject.toml b/pyproject.toml
@@ -10,7 +10,7 @@ description = "Universal Cloud Knowledge Navigator - AI-Powered Code and Error S
 readme = "README.md"
 license = {text = "MIT"}
 dynamic = ["version"]
-requires-python = ">=3.8"
+requires-python = ">=3.11"
 dependencies = [
     # Core dependencies
     "fastapi>=0.100.0",
@@ -83,14 +83,11 @@ quality = [
     "types-requests>=2.31.0",
     "types-aiofiles>=23.0.0",
 ]
-# Extended quality tools (for comprehensive analysis)
+# Extended quality tools (for comprehensive analysis) - pip only, not pixi
 quality-extended = [
     "vulture>=2.7",  # Dead code detection
     "xenon>=0.9.0",  # Complexity analysis
     "radon>=6.0.0",  # Code metrics
-    "interrogate>=1.5.0",  # Documentation coverage
-    "semgrep>=1.35.0",  # Static analysis security
-    "prospector>=1.10.0",  # Multi-tool analysis
 ]
 # CI-specific quality tools (optimized for CI environments)
 quality-ci = [
@@ -148,29 +145,69 @@ packages = ["src/uckn"]
 include = ["src/uckn", "tests", "pyproject.toml", "README.md"]
 
 [tool.pixi.project]
-channels = ["conda-forge", "pytorch", "nvidia"]
-platforms = ["linux-64", "win-64", "osx-64", "osx-arm64"]
+channels = ["conda-forge", "pytorch", "nvidia", "dnachun"]
+platforms = ["linux-64"]
 
 # NO pypi-dependencies - all dependencies come from conda-forge only
 # The package is installed separately via pip install -e . after pixi install
 
 [tool.pixi.feature.core.dependencies]
 # System dependencies
 python = "3.12.*"
-# Core runtime dependencies (MINIMAL SET)
 pip = "*"
-# CLI and development utilities
 git = "*"
 
+[tool.pixi.feature.quality.dependencies]
+# Quality tools from conda-forge
+pytest = ">=8.0.0"
+pytest-cov = ">=4.0.0"
+pytest-asyncio = ">=0.21.0"
+pytest-timeout = ">=2.1.0"
+pytest-benchmark = ">=4.0.0"
+mypy = ">=1.5.0"
+ruff = ">=0.0.290"
+coverage = ">=7.3.0"
+
+[tool.pixi.feature.quality-extended.dependencies]
+# Extended quality tools from conda-forge/dnachun
+bandit = ">=1.7.5"
+vulture = ">=2.7"
+radon = ">=6.0.0"
+interrogate = ">=1.5.0"
+prospector = ">=1.10.0"
+# NOTE: semgrep moved to separate environment (requires Python 3.11)
+
+[tool.pixi.feature.semgrep.dependencies]
+# Semgrep requires Python 3.11 (incompatible with 3.12)
+python = "3.11.*"
+semgrep = ">=1.35.0"
+
+[tool.pixi.feature.dev.dependencies]
+# Development tools from conda-forge
+black = ">=23.0.0"
+isort = ">=5.12.0"
+pre-commit = ">=3.0.0"
+
+[tool.pixi.feature.loadtest.dependencies]
+# Load testing from conda-forge
+locust = ">=2.15.0"
+
+[tool.pixi.feature.docs.dependencies]
+# Documentation from conda-forge
+mkdocs = ">=1.5.0"
+mkdocs-material = ">=9.0.0"
+
 [tool.pixi.environments]
-# All environments use only conda-forge dependencies (core feature)
-# Additional Python packages are installed via pip after pixi install
+# All dependencies from conda-forge only
 default = {features = ["core"], solve-group = "default"}
-dev = {features = ["core"], solve-group = "default"}
-ci = {features = ["core"], solve-group = "default"}
-docs = {features = ["core"], solve-group = "default"}
-quality = {features = ["core"], solve-group = "default"}
-quality-extended = {features = ["core"], solve-group = "default"}
+dev = {features = ["core", "quality", "dev"], solve-group = "default"}
+ci = {features = ["core", "quality"], solve-group = "default"}
+quality = {features = ["core", "quality"], solve-group = "default"}
+quality-extended = {features = ["core", "quality", "quality-extended"], solve-group = "default"}
+loadtest = {features = ["core", "loadtest"], solve-group = "default"}
+docs = {features = ["core", "docs"], solve-group = "default"}
+# Semgrep requires Python 3.11 - separate solve-group
+semgrep = {features = ["semgrep"], solve-group = "semgrep"}
 
 [tool.pixi.tasks]
 # Development tasks (STRICT COMPLIANCE: Use pip module with python)
@@ -282,8 +319,21 @@ filterwarnings = [
 [tool.pytest_asyncio]
 asyncio_mode = "auto"  # Automatically detect and run async tests
 
-[tool.pytest.benchmark]
-disable = false
+# pytest-benchmark settings moved to conftest.py or CLI args
+# [tool.pytest.benchmark] removed - conflicts with [tool.pytest.ini_options]
+
+[tool.ruff]
+target-version = "py311"
+line-length = 88
+
+[tool.ruff.lint]
+select = ["F", "E9"]
+ignore = []
+
+[tool.ruff.lint.per-file-ignores]
+# Allow star imports in conftest.py for pytest fixtures
+"tests/conftest.py" = ["F403", "F405"]
+"tests/**/conftest.py" = ["F403", "F405"]
 
 [tool.mypy]
 python_version = "3.12"
diff --git a/tests/benchmarks/test_performance_benchmarks.py b/tests/benchmarks/test_performance_benchmarks.py
@@ -7,10 +7,8 @@
 
 import gc
 import os
-import tempfile
 import time
 from pathlib import Path
-from typing import Any
 
 import pytest
 
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -4,7 +4,6 @@
 import tempfile
 from collections.abc import Generator
 from pathlib import Path
-from typing import Any
 
 import pytest
 
@@ -124,7 +123,6 @@ def factory(
         tech_detector = tech_detector or TechStackDetector()
         # Create unified_db for PatternManager
         from tests.fixtures.database_fixtures import DummyUnifiedDatabase
-        from uckn.storage.unified_database import UnifiedDatabase
 
         unified_db = DummyUnifiedDatabase()
         pattern_manager = pattern_manager or PatternManager(unified_db, semantic_search)
diff --git a/tests/e2e/test_e2e_basic_workflow.py b/tests/e2e/test_e2e_basic_workflow.py
@@ -1,7 +1,6 @@
 import os
 import shutil
 import tempfile
-import time
 
 import pytest
 
diff --git a/tests/fixtures/database_fixtures.py b/tests/fixtures/database_fixtures.py
@@ -14,7 +14,7 @@
 import logging
 import uuid
 from datetime import datetime
-from typing import Any, Optional
+from typing import Any
 
 import pytest
 
diff --git a/tests/integration/test_centralized_architecture.py b/tests/integration/test_centralized_architecture.py
@@ -1,23 +1,14 @@
-import os
 import shutil
 import uuid
-from datetime import datetime
 from pathlib import Path
 
 import pytest
 
 from src.uckn.core.organisms.knowledge_manager import KnowledgeManager
-from src.uckn.storage.chromadb_connector import ChromaDBConnector
 from src.uckn.storage.postgresql_connector import (
     Base,
-    ErrorSolution,
-    Pattern,
-    PatternCategory,
-    PatternCategoryLink,
     PostgreSQLConnector,
-    Project,
 )
-from src.uckn.storage.unified_database import UnifiedDatabase
 
 # Use a temporary directory for ChromaDB and an in-memory SQLite for PostgreSQL
 # For true integration testing, a Dockerized PostgreSQL might be preferred,
@@ -102,7 +93,6 @@ def test_knowledge_manager_full_lifecycle_pattern(knowledge_manager_instance):
         print("Running integration test with semantic search disabled")
 
     # 1. Add a Project with unique name
-    import uuid
 
     unique_name = f"Test Project {uuid.uuid4().hex[:8]}"
     project_id = km.add_project(
diff --git a/tests/integration/test_knowledge_manager_integration.py b/tests/integration/test_knowledge_manager_integration.py
@@ -1,4 +1,3 @@
-import os
 import shutil
 import tempfile
 import time
diff --git a/tests/integration/test_performance_integration.py b/tests/integration/test_performance_integration.py
@@ -1,4 +1,3 @@
-import pytest
 
 from src.uckn.core.atoms.multi_modal_embeddings_optimized import (
     MultiModalEmbeddingsOptimized,
diff --git a/tests/load_tests/locustfile.py b/tests/load_tests/locustfile.py
@@ -2,9 +2,8 @@
 UCKN Load Testing Entry Point (Locust)
 """
 
-import os
 
-from locust import HttpUser, between, events
+from locust import between, events
 
 from .scenarios.mixed_workload import MixedWorkloadUser
 from .scenarios.pattern_scenarios import PatternAdditionUser
diff --git a/tests/load_tests/scenarios/mixed_workload.py b/tests/load_tests/scenarios/mixed_workload.py
@@ -2,7 +2,6 @@
 Locust scenario: Mixed workload (80% search, 20% add) for UCKN
 """
 
-import random
 
 from locust import HttpUser, TaskSet, tag, task
 
diff --git a/tests/load_tests/scenarios/pattern_scenarios.py b/tests/load_tests/scenarios/pattern_scenarios.py
@@ -2,7 +2,6 @@
 Locust scenario: Concurrent pattern addition for UCKN
 """
 
-import random
 
 from locust import HttpUser, TaskSet, tag, task
 
diff --git a/tests/load_tests/scenarios/search_scenarios.py b/tests/load_tests/scenarios/search_scenarios.py
@@ -2,7 +2,6 @@
 Locust scenario: High-volume search simulation for UCKN
 """
 
-import random
 
 from locust import HttpUser, TaskSet, tag, task
 
diff --git a/tests/load_tests/utils/monitoring.py b/tests/load_tests/utils/monitoring.py
@@ -2,7 +2,6 @@
 Resource and performance monitoring for UCKN load tests.
 """
 
-import os
 import threading
 import time
 
diff --git a/tests/quality_metrics/coverage_analysis.py b/tests/quality_metrics/coverage_analysis.py
@@ -9,7 +9,7 @@
 import json
 import os
 from datetime import datetime
-from typing import Any, Optional
+from typing import Any
 
 COVERAGE_JSON = os.environ.get("UCKN_COVERAGE_JSON", "coverage.json")
 COVERAGE_MD = os.environ.get("UCKN_COVERAGE_MD", "coverage.md")
diff --git a/tests/quality_metrics/quality_dashboard.py b/tests/quality_metrics/quality_dashboard.py
@@ -14,7 +14,6 @@
 
 from tests.quality_metrics.coverage_analysis import (
     extract_coverage_metrics,
-    generate_markdown_summary,
     load_coverage_json,
     print_coverage_trend,
 )
diff --git a/tests/test_semantic_search_enhanced.py b/tests/test_semantic_search_enhanced.py
@@ -8,9 +8,8 @@
 import json
 import os
 import shutil
-import tempfile
 from pathlib import Path
-from unittest.mock import MagicMock, call, patch
+from unittest.mock import MagicMock, patch
 
 import numpy as np
 import pytest
diff --git a/tests/unit/api/test_collaboration_router.py b/tests/unit/api/test_collaboration_router.py
@@ -2,20 +2,16 @@
 Tests for collaboration API router.
 """
 
-import json
 from datetime import datetime, timezone
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import MagicMock, patch
 
 import pytest
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
 
 from src.uckn.core.molecules.collaboration_manager import (
-    ActivityEvent,
     CollaborationManager,
     Comment,
-    NotificationPreference,
-    WebhookConfig,
 )
 
 
diff --git a/tests/unit/api/test_predictions_router.py b/tests/unit/api/test_predictions_router.py
@@ -1,5 +1,4 @@
-from datetime import datetime
-from unittest.mock import Mock, patch
+from unittest.mock import Mock
 
 import pytest
 from fastapi import FastAPI
diff --git a/tests/unit/api/test_workflow_router.py b/tests/unit/api/test_workflow_router.py
@@ -12,10 +12,8 @@
     ReviewFeedback,
     ReviewStatus,
     SubmitReviewFeedbackRequest,
-    WorkflowActionResponse,
     WorkflowState,
     WorkflowStatusResponse,
-    WorkflowTransitionRequest,
 )
 
 # Import the router and its dependencies
diff --git a/tests/unit/atoms/test_pattern_extractor.py b/tests/unit/atoms/test_pattern_extractor.py
@@ -3,7 +3,6 @@
 """
 
 import unittest
-from pathlib import Path
 from unittest.mock import MagicMock
 
 from src.uckn.core.atoms.pattern_extractor import PatternExtractor
diff --git a/tests/unit/atoms/test_project_dna_fingerprinter.py b/tests/unit/atoms/test_project_dna_fingerprinter.py
@@ -1,5 +1,3 @@
-import json
-import os
 import tempfile
 
 import pytest
diff --git a/tests/unit/atoms/test_semantic_search_engine.py b/tests/unit/atoms/test_semantic_search_engine.py
@@ -1,4 +1,3 @@
-from unittest.mock import MagicMock
 
 import pytest
 
diff --git a/tests/unit/mcp/test_mcp_tools.py b/tests/unit/mcp/test_mcp_tools.py
@@ -2,7 +2,6 @@
 Simple tests for MCP tools functionality
 """
 
-import json
 import os
 import tempfile
 
diff --git a/tests/unit/mcp/test_universal_knowledge_server.py b/tests/unit/mcp/test_universal_knowledge_server.py
@@ -3,9 +3,8 @@
 """
 
 import json
-import os
 import tempfile
-from unittest.mock import AsyncMock, MagicMock, Mock, patch
+from unittest.mock import MagicMock, Mock, patch
 
 import pytest
 
diff --git a/tests/unit/molecules/test_collaboration_manager.py b/tests/unit/molecules/test_collaboration_manager.py
@@ -2,8 +2,7 @@
 Tests for CollaborationManager.
 """
 
-from datetime import datetime, timezone
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import AsyncMock, MagicMock
 
 import pytest
 
diff --git a/tests/unit/molecules/test_error_solution_manager.py b/tests/unit/molecules/test_error_solution_manager.py
@@ -1,4 +1,4 @@
-from unittest.mock import MagicMock, patch
+from unittest.mock import MagicMock
 
 import pytest
 
diff --git a/tests/unit/molecules/test_issue_prediction_models.py b/tests/unit/molecules/test_issue_prediction_models.py
@@ -1,5 +1,4 @@
-import random
-from unittest.mock import Mock, patch
+from unittest.mock import patch
 
 import pytest
 
diff --git a/tests/unit/molecules/test_pattern_analytics.py b/tests/unit/molecules/test_pattern_analytics.py
@@ -2,10 +2,8 @@
 Test Pattern Analytics functionality
 """
 
-from datetime import datetime, timedelta
 from unittest.mock import Mock, patch
 
-import pytest
 
 from uckn.core.molecules.pattern_analytics import PatternAnalytics
 
diff --git a/tests/unit/molecules/test_pattern_migrator.py b/tests/unit/molecules/test_pattern_migrator.py
diff --git a/tests/unit/molecules/test_workflow_manager.py b/tests/unit/molecules/test_workflow_manager.py
diff --git a/tests/unit/organisms/test_pattern_recommendation_engine.py b/tests/unit/organisms/test_pattern_recommendation_engine.py
diff --git a/tests/unit/organisms/test_predictive_issue_detector.py b/tests/unit/organisms/test_predictive_issue_detector.py
diff --git a/tests/unit/performance/test_analytics.py b/tests/unit/performance/test_analytics.py
diff --git a/tests/unit/performance/test_async_processor.py b/tests/unit/performance/test_async_processor.py
diff --git a/tests/unit/performance/test_batch_optimizer.py b/tests/unit/performance/test_batch_optimizer.py
diff --git a/tests/unit/performance/test_cache_manager.py b/tests/unit/performance/test_cache_manager.py
diff --git a/tests/unit/performance/test_db_optimizer.py b/tests/unit/performance/test_db_optimizer.py
diff --git a/tests/unit/performance/test_resource_monitor.py b/tests/unit/performance/test_resource_monitor.py
diff --git a/tests/unit/storage/test_postgresql_connector.py b/tests/unit/storage/test_postgresql_connector.py
diff --git a/tests/unit/storage/test_unified_database.py b/tests/unit/storage/test_unified_database.py
diff --git a/tests/unit/sync/test_sync_manager.py b/tests/unit/sync/test_sync_manager.py

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import os`
`2`	`1`	`import shutil`
`3`	`2`	`import tempfile`
`4`	`3`	`import time`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import pytest`
`2`	`1`
`3`	`2`	`from src.uckn.core.atoms.multi_modal_embeddings_optimized import (`
`4`	`3`	`MultiModalEmbeddingsOptimized,`