fix: resolve collaboration router test failure and psycopg dependency

- Fix collaboration router test dependency injection by overriding FastAPI dependencies
- Replace psycopg[binary] with psycopg2-binary to resolve pixi warnings
- Ensure proper async mock setup for collaboration manager methods
- Add dependency overrides at app fixture level for better test isolation

Error resolved: "Knowledge manager not initialized" 503 error
Quality: Test now passes with 201 status as expected

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

Author: MementoRC

pyproject.toml

@@ -38,7 +38,7 @@ dependencies = [
     "redis>=4.0.0",
     "psutil>=5.9.0",
     "SQLAlchemy>=2.0.0", # Added for PostgreSQL ORM
-    "psycopg[binary]>=3.1.0", # Added for PostgreSQL driver
+    "psycopg2-binary>=2.9.0", # PostgreSQL driver with binary support
     "alembic>=1.12.0", # Added for database migrations
 ]
 
@@ -142,7 +142,7 @@ pytorch = "*"
 sentence-transformers = "*"
 chromadb = "*"
 SQLAlchemy = "*" # Added for PostgreSQL ORM
-psycopg = "*" # Added for PostgreSQL driver
+psycopg2-binary = "*" # PostgreSQL driver with binary support
 
 [tool.pixi.environments]
 default = {features = ["ml", "mcp"], solve-group = "default"}

tests/unit/api/test_collaboration_router.py

@@ -9,6 +9,11 @@
 from fastapi.testclient import TestClient
 from fastapi import FastAPI
 
+# Import the actual dependencies to override them
+from src.uckn.api.dependencies import get_knowledge_manager as original_get_knowledge_manager
+from src.uckn.api.routers.collaboration import get_collaboration_manager as original_get_collaboration_manager
+from src.uckn.api.routers.collaboration import router # Import the router itself
+
 from src.uckn.core.molecules.collaboration_manager import (
     CollaborationManager,
     ActivityEvent,
@@ -19,12 +24,13 @@
 
 
 @pytest.fixture
-def app():
-    """Create FastAPI app for testing."""
+def app(mock_knowledge_manager, mock_collaboration_manager):
+    """Create FastAPI app for testing with dependency overrides."""
     app = FastAPI()
 
-    # Import and include router with dependency override
-    from src.uckn.api.routers.collaboration import router
+    # Override dependencies
+    app.dependency_overrides[original_get_knowledge_manager] = lambda: mock_knowledge_manager
+    app.dependency_overrides[original_get_collaboration_manager] = lambda: mock_collaboration_manager
 
     app.include_router(router, prefix="/api/v1")
     return app
@@ -39,28 +45,39 @@ def client(app):
 @pytest.fixture
 def mock_collaboration_manager():
     """Create mock collaboration manager."""
-    return MagicMock(spec=CollaborationManager)
+    mock_manager = MagicMock(spec=CollaborationManager)
+    # Explicitly make async methods AsyncMock
+    mock_manager.add_comment = AsyncMock()
+    mock_manager.get_comments = AsyncMock()
+    mock_manager.get_activity_feed = AsyncMock()
+    mock_manager.set_notification_preference = AsyncMock()
+    mock_manager.add_webhook = AsyncMock()
+    return mock_manager
 
 
 @pytest.fixture
 def mock_knowledge_manager():
     """Create mock knowledge manager."""
-    return MagicMock()
+    # The knowledge manager is used by CollaborationManager constructor
+    # and also by the share_pattern endpoint directly.
+    # It needs to have a get_pattern method if share_pattern is tested.
+    mock_km = MagicMock()
+    # Provide a default return value for get_pattern if it's called by other endpoints
+    mock_km.get_pattern.return_value = {"id": "pattern-456", "name": "Test Pattern"}
+    return mock_km
 
 
 class TestCollaborationRouter:
     """Test cases for collaboration router endpoints."""
 
-    @patch('src.uckn.api.routers.collaboration.get_collaboration_manager')
-    def test_add_comment_success(self, mock_get_collab_manager, client, mock_collaboration_manager):
+    # No need for @patch here as dependencies are overridden in the app fixture
+    def test_add_comment_success(self, client, mock_collaboration_manager):
         """Test successful comment addition."""
-        # Set up mock
-        mock_get_collab_manager.return_value = mock_collaboration_manager
-        
+        # Set up mock return value for the async method
         mock_comment = Comment(
             id="comment-123",
             pattern_id="pattern-456",
-            user_id="mock_user_id",
+            user_id="mock_user_id", # This is hardcoded in the endpoint
             content="Great pattern!",
             metadata={"source": "web"},
             created_at=datetime.now(timezone.utc)
@@ -84,13 +101,17 @@ def test_add_comment_success(self, mock_get_collab_manager, client, mock_collabo
         assert data["pattern_id"] == "pattern-456"
         assert data["content"] == "Great pattern!"
         assert data["user_id"] == "mock_user_id"
+        # Verify the mock was called correctly
+        mock_collaboration_manager.add_comment.assert_called_once()
+        # Optionally, check the arguments passed to add_comment
+        called_comment = mock_collaboration_manager.add_comment.call_args[0][0]
+        assert called_comment.pattern_id == "pattern-456"
+        assert called_comment.user_id == "mock_user_id"
+        assert called_comment.content == "Great pattern!"
 
-    @patch('src.uckn.api.routers.collaboration.get_collaboration_manager')
-    def test_get_comments(self, mock_get_collab_manager, client, mock_collaboration_manager):
+    def test_get_comments(self, client, mock_collaboration_manager):
         """Test getting comments for a pattern."""
-        # Set up mock
-        mock_get_collab_manager.return_value = mock_collaboration_manager
-        
+        # Set up mock return value for the async method
         mock_comments = [
             Comment(
                 id="comment-1",
@@ -109,6 +130,7 @@ def test_get_comments(self, mock_get_collab_manager, client, mock_collaboration_
         data = response.json()
         assert len(data) == 1
         assert data[0]["id"] == "comment-1"
+        mock_collaboration_manager.get_comments.assert_called_once_with("pattern-123", None)
 
     def test_create_pattern_library(self, client):
         """Test creating a team-scoped pattern library."""
@@ -125,4 +147,6 @@ def test_create_pattern_library(self, client):
         assert response.status_code == 201
         data = response.json()
         assert data["team_id"] == "team-123"
-        assert data["name"] == "CI/CD Patterns"
+        assert data["name"] == "CI/CD Patterns"
+        assert "id" in data # Ensure an ID is generated
+        assert "created_at" in data # Ensure timestamp is present