🚑 Continue after error that appears when using a Yubikey 5

Stephanie Lakner · MeneDev · commit d51de19a33cb · 2019-10-17T17:44:31.000+02:00
Trying to read the Yubikey's serial fails for the Yubikey 5. But since we don't use the serial anywhere, this is not critical or harmful and we can continue as if nothing happened.
diff --git a/yubikey/scard/scard_yubikey.go b/yubikey/scard/scard_yubikey.go
@@ -63,13 +63,12 @@ func (key *scardYubiKey) GetCodeWithPassword(pwd string) (string, error) {
 
 	rsp, err := key.selectAid(AID_OTP)
 	if err != nil {
-		return "", err
+		fmt.Printf("Error setting 'AID_OTP': %s\n", err)
 	}
 
 	serial, err := key.readSerial()
 	if err != nil {
-		fmt.Println("Error Transmit:", err)
-		return "", err
+		fmt.Printf("Error reading serial: %s\n", err)
 	}
 	fmt.Printf("% 0x \n", rsp)
 	fmt.Printf("serial %d\n", serial)

Original file line number	Diff line number	Diff line change
`@@ -63,13 +63,12 @@ func (key *scardYubiKey) GetCodeWithPassword(pwd string) (string, error) {`
`63`	`63`
`64`	`64`	`rsp, err := key.selectAid(AID_OTP)`
`65`	`65`	`if err != nil {`
`66`		`- return "", err`
	`66`	`+ fmt.Printf("Error setting 'AID_OTP': %s\n", err)`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`serial, err := key.readSerial()`
`70`	`70`	`if err != nil {`
`71`		`- fmt.Println("Error Transmit:", err)`
`72`		`- return "", err`
	`71`	`+ fmt.Printf("Error reading serial: %s\n", err)`
`73`	`72`	`}`
`74`	`73`	`fmt.Printf("% 0x \n", rsp)`
`75`	`74`	`fmt.Printf("serial %d\n", serial)`