V5.4.4

Dev meow

Author: MeowServer

HintServiceExample/Plugin.cs

@@ -17,7 +17,7 @@ public class Plugin : LabApi.Loader.Features.Plugins.Plugin
         public override string Name => "HintServiceExample";
         public override string Author => "MeowServer";
         public override string Description => "A example plugin for HSM";
-        public override Version Version { get; } = new Version(5, 4, 3);
+        public override Version Version { get; } = new Version(5, 4, 4);
         public override Version RequiredApiVersion { get; } = Version.Parse(LabApi.Features.LabApiProperties.CompiledVersion);
         public override void Enable()
         {

HintServiceMeow.Tests/PeriodicRunnerTests.cs

@@ -68,15 +68,15 @@ public async Task PauseAndResume_Works()
                        ShortInterval))
             {
                 await Task.Delay(GetLength(ShortInterval, 3));
-                int beforePause = count;
 
                 runner.Pause();
+                int before = count;
                 await Task.Delay(GetLength(ShortInterval, 4));
-                Assert.AreEqual(beforePause, count);
+                Assert.AreEqual(before, count);
 
                 runner.Resume();
                 await Task.Delay(GetLength(ShortInterval, 3));
-                Assert.IsTrue(count > beforePause);
+                Assert.IsTrue(count > before);
             }
         }
 

HintServiceMeow.Tests/TaskSchedulerTests.cs

@@ -121,16 +121,26 @@ public void Pause_And_Resume_Work_AsExpected()
         [TestMethod]
         public void IsReadyForNextAction_ReturnsFalse_IfElapsedLessThanInterval()
         {
-            _scheduler.Start(TimeSpan.FromMilliseconds(200), () => { });
+            _scheduler.Start(TimeSpan.FromMilliseconds(200), () =>
+            {
+                Console.WriteLine($"Action Executed at {DateTime.Now}");
+            });
+            _scheduler.Invoke();
+            Thread.Sleep(100/6);
             Assert.IsFalse(_scheduler.IsReadyForNextAction);
         }
 
         [TestMethod]
         public void IsReadyForNextAction_ReturnsTrue_IfElapsedGreaterThanInterval()
         {
-            _scheduler.Start(TimeSpan.FromMilliseconds(1), () => { });
+            _scheduler.Start(TimeSpan.FromMilliseconds(1), () =>
+            {
+                Console.WriteLine($"Action Executed at {DateTime.Now}");
+            });
+            _scheduler.Invoke();
 
-            Thread.Sleep(3);
+            Thread.Sleep(100/6); // Wait for 1 tick
+            Thread.Sleep(10); // Wait for interval
 
             Console.WriteLine($"Elapsed for {_scheduler.Elapsed} since last action");
             Assert.IsTrue(_scheduler.IsReadyForNextAction);

HintServiceMeow/Core/Utilities/PlayerDisplay.cs

@@ -165,7 +165,7 @@ private IEnumerator<float> CoroutineMethod()
                 yield return Timing.WaitForOneFrame;
 
                 //If player has quit, then stop the coroutine
-                if (this._playerContext.IsValid())
+                if (!this._playerContext.IsValid())
                     break;
 
                 //Reset the success flag

HintServiceMeow/Core/Utilities/TaskScheduler.cs

@@ -14,13 +14,14 @@ internal class TaskScheduler : Interface.ITaskScheduler, Interface.IDestructible
         private DateTime _scheduledActionTime; // Indicate when the timer will begin trying invoking the action
         private TimeSpan _interval; // Minimum time between two actions
         private DateTime _startTimeStamp; // Used to calculate elapsed time since last action, = DateTime.MinValue if there's no last action.
-        private TimeSpan _elapsed; // Time elapsed since last action, does not include the time when the scheduler is paused. If there's not last action, it is DateTime.Now - DateTime.MinValue.
+        private TimeSpan _elapsed; // Time elapsed since last action, does not include the time when the scheduler is paused.
         private bool _paused = false;
         private PeriodicRunner runner;
         public bool IsPaused => _paused;
 
         /// <summary>
         /// Time elapsed since last action. Does not include the time when the scheduler is paused.
+        /// If there's no last action, it is DateTime.Now - DateTime.MinValue.
         /// </summary>
         public TimeSpan Elapsed
         {

HintServiceMeow/HintServiceMeow.csproj

@@ -29,7 +29,7 @@
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'">
     <OutputPath>bin\x64\Release\</OutputPath>
-    <DefineConstants>TRACE;EXILED</DefineConstants>
+    <DefineConstants>TRACE</DefineConstants>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Optimize>true</Optimize>
     <DebugType>pdbonly</DebugType>

HintServiceMeow/Plugin/Plugin.cs

@@ -27,13 +27,13 @@ internal class Plugin : LabApi.Loader.Features.Plugins.Plugin
 #if EXILED
         public override string Name => "HintServiceMeow";
         public override string Author => "MeowServer";
-        public override Version Version => new(5, 4, 3);
+        public override Version Version => new(5, 4, 4);
         public override Version RequiredExiledVersion => new(9, 6, 0);
         public override Exiled.API.Enums.PluginPriority Priority => Exiled.API.Enums.PluginPriority.Highest;
 #else
         public override string Name => "HintServiceMeow";
         public override string Author => "MeowServer";
-        public override Version Version => new(5, 4, 3);
+        public override Version Version => new(5, 4, 4);
         public override Version RequiredApiVersion => new(LabApiProperties.CompiledVersion);
         public override string Description => "A hint framework";
         public override LoadPriority Priority => LoadPriority.Highest;

HintServiceMeow/Properties/AssemblyInfo.cs

@@ -32,7 +32,7 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("5.4.3.0")]
+[assembly: AssemblyVersion("5.4.4.0")]
 [assembly: AssemblyFileVersion("1.0.0.0")]
 
 // Publicize internal types to the test project

HintServiceMeow/UpdateLog.txt

@@ -187,4 +187,6 @@
 -	V5.4.2
 -		Fix a bug that cause CA not to clear the hint correctly
 -	V5.4.3
--		Fix a bug that cause CoordinateTool::GetTextWidth to throw exception when handling empty string
+-		Fix a bug that cause CoordinateTool::GetTextWidth to throw exception when handling empty string
+-	V5.4.4
+-		Fix a bug that cause PlayerDisplay::CoroutineMethod not working correctly