chore(ci-insights): Remove support for MERGIFY_TEST_FLAKY_DETECTION variable

The goal of this change is to stop supporting this variable because we
want to dynamically set span attributes with our clients
(`pytest-mergify`) instead.

References: MRGFY-6218
Change-Id: I2039ca71b2509eada298ccb67032c55512981b44

Author: remyduthu

mergify_cli/ci/detector.py

@@ -202,7 +202,3 @@ def get_github_repository() -> str | None:
             return _get_github_repository_from_env("GIT_URL")
         case _:
             return None
-
-
-def is_flaky_test_detection_enabled() -> bool:
-    return utils.get_boolean_env("MERGIFY_TEST_FLAKY_DETECTION")

mergify_cli/ci/junit_processing/junit.py

@@ -125,9 +125,6 @@ async def junit_to_spans(
     if (provider := detector.get_ci_provider()) is not None:
         resource_attributes["cicd.provider.name"] = provider
 
-    if detector.is_flaky_test_detection_enabled():
-        resource_attributes["mergify.test.flaky_detection_enabled"] = True
-
     resource = resources.Resource.create(resource_attributes)
 
     traceparent = os.environ.get("MERGIFY_TRACEPARENT")

mergify_cli/tests/ci/test_detector.py

@@ -163,28 +163,3 @@ def test_get_github_pull_request_number_unsupported_ci(
 
     result = detector.get_github_pull_request_number()
     assert result is None
-
-
-@pytest.mark.parametrize(
-    ("env_value", "expected"),
-    [
-        ("true", True),
-        ("1", True),
-        ("yes", True),
-        ("", False),
-        ("false", False),
-    ],
-)
-def test_is_flaky_test_detection_enabled(
-    monkeypatch: pytest.MonkeyPatch,
-    *,
-    env_value: str,
-    expected: bool,
-) -> None:
-    if env_value:
-        monkeypatch.setenv("MERGIFY_TEST_FLAKY_DETECTION", env_value)
-    else:
-        monkeypatch.delenv("MERGIFY_TEST_FLAKY_DETECTION", raising=False)
-
-    result = detector.is_flaky_test_detection_enabled()
-    assert result == expected

mergify_cli/tests/ci/test_junit.py

@@ -48,7 +48,6 @@ async def test_parse(
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
     monkeypatch.setenv("_MERGIFY_TEST_JOB_NAME", "foobar")
-    monkeypatch.setenv("MERGIFY_TEST_FLAKY_DETECTION", "1")
     filename = pathlib.Path(__file__).parent / "junit_example.xml"
     run_id = (32312).to_bytes(8, "big").hex()
     spans = await junit.junit_to_spans(
@@ -79,7 +78,6 @@ async def test_parse(
         "telemetry.sdk.name": "opentelemetry",
         "telemetry.sdk.version": anys.ANY_STR,
         "mergify.test.job.name": "foobar",
-        "mergify.test.flaky_detection_enabled": True,
     }
     assert dictified_spans == [
         {
@@ -555,6 +553,3 @@ async def test_traceparent_injection(
     assert spans[0].parent.span_id == 0x7A085853722DC6D2
     for span in spans:
         assert span.context.trace_id == 0x80E1AFED08E019FC1110464CFA66635C
-
-        # Flaky test detection is disabled by default.
-        assert "mergify.test.flaky_detection_enabled" not in span.resource.attributes