refactor: Remove is_processed flag from test metrics (#335)

The goal of this change is to simplify the process and simply use the
deadline to know if a test has already been processed. If a deadline is
set for the given test, it means it has been processed.

Depends-On: #334

Author: remyduthu

pytest_mergify/flaky_detection.py

@@ -59,10 +59,6 @@ def initial_duration(self) -> datetime.timedelta:
             + self.initial_teardown_duration
         )
 
-    # NOTE(remyduthu): We need this flag because we may have processed a test
-    # without scheduling reruns for it (e.g., because it was too slow).
-    is_processed: bool = dataclasses.field(default=False)
-
     rerun_count: int = dataclasses.field(default=0)
     "Represents the number of times the test has been rerun so far."
 
@@ -309,7 +305,6 @@ def set_test_deadline(
         metrics.deadline = datetime.datetime.now(datetime.timezone.utc) + (
             self._get_remaining_budget_duration() / self._count_remaining_tests()
         )
-        metrics.is_processed = True
 
         if not timeout:
             return
@@ -359,7 +354,7 @@ def _count_remaining_tests(self) -> int:
             tests = self._context.unhealthy_test_names
 
         already_processed_tests = {
-            test for test, metrics in self._test_metrics.items() if metrics.is_processed
+            test for test, metrics in self._test_metrics.items() if metrics.deadline
         }
 
         return max(len(tests) - len(already_processed_tests), 1)

tests/test_flaky_detection.py

@@ -106,7 +106,9 @@ def test_flaky_detector_count_remaining_tests() -> None:
         existing_test_names=["foo", "bar", "baz"]
     )
     detector._test_metrics = {
-        "foo": flaky_detection._TestMetrics(is_processed=True),
+        "foo": flaky_detection._TestMetrics(
+            deadline=datetime.datetime.now(datetime.timezone.utc)
+        ),
         "bar": flaky_detection._TestMetrics(),
         "baz": flaky_detection._TestMetrics(),
     }