fix(ci-insights): Set mergify.test.flaky_detection_enabled as a boolean (#173)

Author: remyduthu

pytest_mergify/resources/mergify.py

@@ -1,3 +1,5 @@
+import os
+
 from opentelemetry.sdk.resources import Resource, ResourceDetector
 
 from pytest_mergify import utils
@@ -7,13 +9,24 @@ class MergifyResourceDetector(ResourceDetector):
     """Detects OpenTelemetry Resource attributes for Mergify fields."""
 
     OPENTELEMETRY_MERGIFY_MAPPING = {
-        "mergify.test.flaky_detection_enabled": (
-            str,
-            "MERGIFY_TEST_FLAKY_DETECTION_ENABLED",
-        ),
         "mergify.test.job.name": (str, "MERGIFY_TEST_JOB_NAME"),
     }
 
     def detect(self) -> Resource:
         attributes = utils.get_attributes(self.OPENTELEMETRY_MERGIFY_MAPPING)
+
+        if _is_flaky_test_detection_enabled():
+            attributes["mergify.test.flaky_detection_enabled"] = True
+
         return Resource(attributes)
+
+
+def _is_flaky_test_detection_enabled() -> bool:
+    return os.getenv("MERGIFY_TEST_FLAKY_DETECTION", default="").lower() in {
+        "y",
+        "yes",
+        "t",
+        "true",
+        "on",
+        "1",
+    }

tests/test_resources.py

@@ -37,13 +37,13 @@ def test_span_resources_attributes_mergify(
     pytester_with_spans: conftest.PytesterWithSpanT,
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:
-    monkeypatch.setenv("MERGIFY_TEST_FLAKY_DETECTION_ENABLED", "true")
+    monkeypatch.setenv("MERGIFY_TEST_FLAKY_DETECTION", "yes")
     monkeypatch.setenv("MERGIFY_TEST_JOB_NAME", "f00b4r")
 
     result, spans = pytester_with_spans()
     assert spans is not None
     assert all(
-        span.resource.attributes["mergify.test.flaky_detection_enabled"] == "true"
+        span.resource.attributes["mergify.test.flaky_detection_enabled"] is True
         for span in spans.values()
     )
     assert all(