Spawning inside planet when planets too close together

[Koruzarius]

I created a world with a tight cluster of planets, and I keep getting spawns showing up inside the planet, or upside down in the sky and immediately crashing into the planet. Anyone else seen this before and have any idea if there's a workaround?

[Koruzarius]

After digging into it myself, I think replacing the GetNearestPlanet function in PlanetManager.cs
with the updated version below will fix it.

The problem seems to be it is looking for what planet center you are closest to, but if you have a moon right next to a planet, a large swath of the planet's surface is closer to the core of the moon than the planet.

public static PlanetEntity GetNearestPlanet(Vector3D coords) {

    PlanetEntity planet = null;
    double distance = -1;

    foreach (var planetEnt in Planets) {

        if (planetEnt?.Planet == null)
            continue;

        if (planetEnt.IsPositionInGravity(coords)) {
            var thisDist = Math.Abs(Vector3D.Distance(planetEnt.Center(), coords)-planetEnt.Planet.AverageRadius);

            if (distance == -1 || thisDist < distance) {
                planet = planetEnt;
                distance = thisDist;
            }
        }             
    }
    return planet;
}

This tweaks it to use the distance to the surface of the planet as the comparison distance.

[Koruzarius]

I created a fork, implemented the change, and opened a pull request:
#283