Merge pull request #76 from Merit-Systems/fix/qaqa/I-01

Fix/qaqa/i 01

Author: shafu0x

libraries/Errors.sol

@@ -3,23 +3,8 @@ pragma solidity =0.8.26;
 
 library Errors {
     string internal constant NOT_OWNER                    = "Not Owner";
-    string internal constant NOT_SUPPORTED                = "Not Supported";
-    string internal constant ALREADY_INITIALIZED          = "Already Initialized";
-    string internal constant LENGTH_MISMATCH              = "Length Mismatch";
-    string internal constant ZERO_SHARE                   = "Zero Share";
-    string internal constant NO_TIME_ELAPSED              = "No Time Elapsed";
-    string internal constant NO_NEW_MINTED_SHARES         = "No New Minted Shares";
-    string internal constant NO_PULL_REQUESTS             = "No Pull Requests";
-    string internal constant NO_WEIGHTS                   = "No Weights";
-    string internal constant NOT_INITIALIZED              = "Not Initialized";
-    string internal constant NOT_ACCOUNT_OWNER            = "Not Account Owner";
     string internal constant ALREADY_CLAIMED              = "Already Claimed";
-    string internal constant INVALID_PROOF                = "Invalid Proof";
-    string internal constant INVALID_ROOT                 = "Invalid Root";
-    string internal constant NO_CONTRIBUTORS              = "No Contributors";
-    string internal constant TOO_MANY_CONTRIBUTORS        = "Too Many Contributors";
-    string internal constant TOO_MANY_PULL_REQUESTS       = "Too Many Pull Requests";
-    string internal constant NO_PAYMENT_PERMISSION        = "No Payment Permission";
+    string internal constant NO_CLAIM_PERMISSION          = "No Payment Permission";
     string internal constant CLAIM_EXPIRED                = "Claim Expired";
     string internal constant STILL_CLAIMABLE              = "Still Claimable";
     string internal constant INVALID_SIGNATURE            = "Invalid Signature";
@@ -36,4 +21,5 @@ library Errors {
     string internal constant INVALID_AMOUNT_AFTER_FEE     = "Invalid Amount After Fee";
     string internal constant INVALID_BATCH_DEPOSIT_LIMIT  = "Invalid Batch Deposit Limit";
     string internal constant BATCH_DEPOSIT_LIMIT_EXCEEDED = "Batch Deposit Limit Exceeded";
+    string internal constant EMPTY_BATCH                  = "Empty Batch";
 }

src/Escrow.sol

@@ -131,6 +131,7 @@ contract Escrow is Owned, IEscrow {
         external 
         returns (uint[] memory depositIds) 
     {
+        require(params.length > 0,                  Errors.EMPTY_BATCH);
         require(params.length <= batchDepositLimit, Errors.BATCH_DEPOSIT_LIMIT_EXCEEDED);
         depositIds = new uint[](params.length);
 
@@ -155,7 +156,7 @@ contract Escrow is Owned, IEscrow {
         bytes32 s
     ) external {
         setCanClaim(recipient, status, deadline, v, r, s);
-        require(canClaim[recipient], Errors.NO_PAYMENT_PERMISSION);
+        require(canClaim[recipient], Errors.NO_CLAIM_PERMISSION);
         _claim(depositId, recipient);
     }
 
@@ -170,7 +171,7 @@ contract Escrow is Owned, IEscrow {
         bytes32         s
     ) external {
         setCanClaim(recipient, status, deadline, v, r, s);
-        require(canClaim[recipient], Errors.NO_PAYMENT_PERMISSION);
+        require(canClaim[recipient], Errors.NO_CLAIM_PERMISSION);
 
         for (uint256 i = 0; i < depositIds.length; i++) {
             _claim(depositIds[i], recipient);