-
Notifications
You must be signed in to change notification settings - Fork 44
Description
We have noticed issues where videos played in AVPro mode sometimes reload for no reason around the 35 second mark with "Retrying load" in the client log. This matches the value of DEFAULT_RETRY_TIMEOUT. It's been difficult to get a reliable repro for this, but from looking at the code, it seems the only way this could happen is if the video begins playing without ResetVideoLoad being called. Perhaps the OnVideoReady event is not being fired in some circumstances.
As such, I tried adding a call to ResetVideoLoad at the top of OnVideoStart. We're using USharpVideo in AVPro mode at scale in YTS and have seen a dramatic decrease in video reload rate after the change, so it would appear this resolved the issue. However, the load/sync logic is a little hard to follow, so this may not be the ideal fix. If you wish, I can PR the change or test any other suggestions you may have.