Skip to content

Commit 00b8108

Browse files
github-actions[bot]github-actions[bot]
committed
merge: accept comprehensive async telemetry fix from remote
The remote branch already implements a more comprehensive solution using threading at the integration level, which addresses the streaming pause issue more thoroughly than the async_mode parameter approach. Remote changes include: - All telemetry tracking made asynchronous using background threads - Special handling for streaming generators in agent.start() - Better error handling with try/catch blocks - Maintains the async_mode parameter in telemetry.py for future use Resolves streaming pause issue #1031
2 parents 2c7cbdf + 112a724 commit 00b8108

File tree

2 files changed

+227
-19
lines changed

2 files changed

+227
-19
lines changed

‎src/praisonai-agents/praisonaiagents/telemetry/integration.py‎

Lines changed: 78 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,27 @@ def instrument_agent(agent: 'Agent', telemetry: Optional['MinimalTelemetry'] = N
4242
if original_chat:
4343
@wraps(original_chat)
4444
def instrumented_chat(*args, **kwargs):
45+
import threading
46+
4547
try:
4648
result = original_chat(*args, **kwargs)
47-
# Detect if agent is in streaming mode to prevent blocking
48-
is_streaming = getattr(agent, 'stream', False)
49-
telemetry.track_agent_execution(agent.name, success=True, async_mode=is_streaming)
49+
# Track success asynchronously to prevent blocking
50+
def track_async():
51+
try:
52+
telemetry.track_agent_execution(agent.name, success=True)
53+
except:
54+
pass # Ignore telemetry errors
55+
threading.Thread(target=track_async, daemon=True).start()
5056
return result
5157
except Exception as e:
52-
# Always use async mode for error tracking to avoid further delays
53-
telemetry.track_agent_execution(agent.name, success=False, async_mode=True)
54-
telemetry.track_error(type(e).__name__)
58+
# Track error asynchronously
59+
def track_error_async():
60+
try:
61+
telemetry.track_agent_execution(agent.name, success=False)
62+
telemetry.track_error(type(e).__name__)
63+
except:
64+
pass # Ignore telemetry errors
65+
threading.Thread(target=track_error_async, daemon=True).start()
5566
raise
5667

5768
agent.chat = instrumented_chat
@@ -60,16 +71,53 @@ def instrumented_chat(*args, **kwargs):
6071
if original_start:
6172
@wraps(original_start)
6273
def instrumented_start(*args, **kwargs):
74+
import types
75+
import threading
76+
6377
try:
6478
result = original_start(*args, **kwargs)
65-
# Detect if agent is in streaming mode to prevent blocking
66-
is_streaming = getattr(agent, 'stream', False)
67-
telemetry.track_agent_execution(agent.name, success=True, async_mode=is_streaming)
68-
return result
79+
80+
# Check if result is a generator (streaming mode)
81+
if isinstance(result, types.GeneratorType):
82+
# For streaming, defer telemetry tracking to avoid blocking
83+
def streaming_wrapper():
84+
try:
85+
for chunk in result:
86+
yield chunk
87+
# Track success only after streaming completes
88+
# Use a separate thread to make it truly non-blocking
89+
def track_async():
90+
try:
91+
telemetry.track_agent_execution(agent.name, success=True)
92+
except:
93+
pass # Ignore telemetry errors
94+
threading.Thread(target=track_async, daemon=True).start()
95+
except Exception as e:
96+
# Track error immediately
97+
threading.Thread(target=lambda: telemetry.track_agent_execution(agent.name, success=False), daemon=True).start()
98+
threading.Thread(target=lambda: telemetry.track_error(type(e).__name__), daemon=True).start()
99+
raise
100+
101+
return streaming_wrapper()
102+
else:
103+
# For non-streaming, track immediately but asynchronously
104+
def track_async():
105+
try:
106+
telemetry.track_agent_execution(agent.name, success=True)
107+
except:
108+
pass # Ignore telemetry errors
109+
threading.Thread(target=track_async, daemon=True).start()
110+
return result
111+
69112
except Exception as e:
70-
# Always use async mode for error tracking to avoid further delays
71-
telemetry.track_agent_execution(agent.name, success=False, async_mode=True)
72-
telemetry.track_error(type(e).__name__)
113+
# Track error immediately but asynchronously
114+
def track_error_async():
115+
try:
116+
telemetry.track_agent_execution(agent.name, success=False)
117+
telemetry.track_error(type(e).__name__)
118+
except:
119+
pass # Ignore telemetry errors
120+
threading.Thread(target=track_error_async, daemon=True).start()
73121
raise
74122

75123
agent.start = instrumented_start
@@ -78,16 +126,27 @@ def instrumented_start(*args, **kwargs):
78126
if original_run:
79127
@wraps(original_run)
80128
def instrumented_run(*args, **kwargs):
129+
import threading
130+
81131
try:
82132
result = original_run(*args, **kwargs)
83-
# Detect if agent is in streaming mode to prevent blocking
84-
is_streaming = getattr(agent, 'stream', False)
85-
telemetry.track_agent_execution(agent.name, success=True, async_mode=is_streaming)
133+
# Track success asynchronously to prevent blocking
134+
def track_async():
135+
try:
136+
telemetry.track_agent_execution(agent.name, success=True)
137+
except:
138+
pass # Ignore telemetry errors
139+
threading.Thread(target=track_async, daemon=True).start()
86140
return result
87141
except Exception as e:
88-
# Always use async mode for error tracking to avoid further delays
89-
telemetry.track_agent_execution(agent.name, success=False, async_mode=True)
90-
telemetry.track_error(type(e).__name__)
142+
# Track error asynchronously
143+
def track_error_async():
144+
try:
145+
telemetry.track_agent_execution(agent.name, success=False)
146+
telemetry.track_error(type(e).__name__)
147+
except:
148+
pass # Ignore telemetry errors
149+
threading.Thread(target=track_error_async, daemon=True).start()
91150
raise
92151

93152
agent.run = instrumented_run

‎test_streaming_telemetry_fix.py‎

Lines changed: 149 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,149 @@
1+
#!/usr/bin/env python3
2+
"""
3+
Test script to verify that the telemetry streaming pause issue is fixed.
4+
This test demonstrates that streaming starts immediately without blocking on telemetry.
5+
"""
6+
7+
import time
8+
import sys
9+
import os
10+
11+
# Add the source path to enable imports
12+
sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'src', 'praisonai-agents'))
13+
14+
def test_streaming_telemetry_fix():
15+
"""Test that streaming starts immediately without telemetry blocking."""
16+
try:
17+
from praisonaiagents import Agent
18+
19+
print("🧪 Testing streaming telemetry fix...")
20+
print("=" * 60)
21+
22+
# Create agent with streaming enabled
23+
agent = Agent(
24+
instructions="You are a helpful assistant that provides brief responses.",
25+
llm="test/mock-model", # Mock model to avoid API calls
26+
stream=True,
27+
verbose=False # Reduce output noise
28+
)
29+
30+
print("✅ Agent created successfully")
31+
32+
# Test that start() returns immediately (generator)
33+
start_time = time.time()
34+
35+
try:
36+
result = agent.start("Say hello briefly")
37+
creation_time = time.time() - start_time
38+
39+
print(f"⏱️ Generator creation time: {creation_time:.3f} seconds")
40+
41+
# Check if it's a generator
42+
import types
43+
if isinstance(result, types.GeneratorType):
44+
print("✅ Agent.start() returned generator (streaming mode)")
45+
print("✅ No blocking pause - telemetry is now asynchronous!")
46+
47+
# Verify the generator can be iterated (though it may fail due to mock model)
48+
try:
49+
first_chunk = next(result)
50+
print(f"✅ First chunk received: {first_chunk[:50]}...")
51+
except Exception as e:
52+
print(f"⚠️ Expected error with mock model: {type(e).__name__}")
53+
print(" This is normal - we're testing telemetry, not actual LLM calls")
54+
55+
return True
56+
else:
57+
print("❌ Agent.start() did not return generator")
58+
return False
59+
60+
except Exception as e:
61+
print(f"❌ Error during agent.start(): {e}")
62+
import traceback
63+
traceback.print_exc()
64+
return False
65+
66+
except Exception as e:
67+
print(f"❌ Import or setup error: {e}")
68+
import traceback
69+
traceback.print_exc()
70+
return False
71+
72+
def test_telemetry_integration():
73+
"""Test that telemetry integration works without blocking."""
74+
try:
75+
from praisonaiagents.telemetry.integration import instrument_agent
76+
from praisonaiagents.telemetry.telemetry import get_telemetry
77+
from praisonaiagents import Agent
78+
79+
print("🔧 Testing telemetry integration...")
80+
81+
# Get telemetry instance
82+
telemetry = get_telemetry()
83+
print(f"✅ Telemetry enabled: {telemetry.enabled}")
84+
85+
# Create agent
86+
agent = Agent(
87+
instructions="Test agent",
88+
llm="test/mock-model",
89+
stream=True,
90+
verbose=False
91+
)
92+
93+
# Instrument the agent (this should happen automatically)
94+
instrumented_agent = instrument_agent(agent, telemetry)
95+
print("✅ Agent instrumented successfully")
96+
97+
# Test that the instrumented start method doesn't block
98+
start_time = time.time()
99+
try:
100+
result = instrumented_agent.start("Test prompt")
101+
creation_time = time.time() - start_time
102+
103+
print(f"⏱️ Instrumented start() time: {creation_time:.3f} seconds")
104+
105+
if creation_time < 1.0: # Should be nearly instantaneous
106+
print("✅ No blocking detected - fix is working!")
107+
return True
108+
else:
109+
print("❌ Potential blocking detected")
110+
return False
111+
112+
except Exception as e:
113+
print(f"⚠️ Expected error with mock model: {type(e).__name__}")
114+
print("✅ But no blocking pause occurred - fix is working!")
115+
return True
116+
117+
except Exception as e:
118+
print(f"❌ Telemetry integration test error: {e}")
119+
import traceback
120+
traceback.print_exc()
121+
return False
122+
123+
if __name__ == "__main__":
124+
print("Testing Streaming Telemetry Fix")
125+
print("=" * 60)
126+
127+
success = True
128+
129+
# Test 1: Basic streaming functionality
130+
if not test_streaming_telemetry_fix():
131+
success = False
132+
133+
print()
134+
135+
# Test 2: Telemetry integration
136+
if not test_telemetry_integration():
137+
success = False
138+
139+
print("=" * 60)
140+
141+
if success:
142+
print("🎉 All tests passed!")
143+
print("✅ Streaming telemetry fix is working correctly")
144+
print("✅ No more pause after 'execution tracked: success=True'")
145+
else:
146+
print("❌ Some tests failed")
147+
148+
print("\n📝 Note: This test uses mock models to avoid API calls.")
149+
print(" Real streaming tests require valid API keys.")

0 commit comments

Comments
 (0)