Merge pull request #941 from MervinPraison/claude/issue-938-20250715-2246

fix: Ensure agent names are valid Python identifiers for AutoGen v0.4

Author: MervinPraison

src/praisonai/praisonai/agents_generator.py

@@ -14,6 +14,8 @@
 import importlib.util
 import os
 import logging
+import re
+import keyword
 
 # Framework-specific imports with availability checks
 CREWAI_AVAILABLE = False
@@ -82,6 +84,40 @@ class BaseTool:
 def noop(*args, **kwargs):
     pass
 
+def sanitize_agent_name_for_autogen_v4(name):
+    """
+    Sanitize agent name to be a valid Python identifier for AutoGen v0.4.
+    
+    Args:
+        name (str): The original agent name
+        
+    Returns:
+        str: A valid Python identifier
+    """
+    # Convert to string and replace invalid characters with underscores
+    sanitized = re.sub(r'[^a-zA-Z0-9_]', '_', str(name))
+    
+    # Collapse only very excessive underscores (5 or more) to reduce extreme cases
+    sanitized = re.sub(r'_{5,}', '_', sanitized)
+    
+    # Remove trailing underscores only if not part of a dunder pattern and only if singular
+    if sanitized.endswith('_') and not sanitized.endswith('__') and sanitized != '_':
+        sanitized = sanitized.rstrip('_')
+    
+    # Ensure it starts with a letter or underscore (not a digit)
+    if sanitized and sanitized[0].isdigit():
+        sanitized = 'agent_' + sanitized
+    
+    # Handle empty string or only invalid characters (including single underscore from all invalid chars)
+    if not sanitized or sanitized == '_':
+        sanitized = 'agent'
+    
+    # Check if it's a Python keyword and append underscore if so
+    if keyword.iskeyword(sanitized):
+        sanitized += '_'
+    
+    return sanitized
+
 def disable_crewai_telemetry():
     if CREWAI_AVAILABLE:
         for attr in dir(Telemetry):
@@ -471,7 +507,9 @@ async def run_autogen_v4_async():
 
             # Create agents from config
             for role, details in config['roles'].items():
+                # For AutoGen v0.4, ensure agent name is a valid Python identifier
                 agent_name = details['role'].format(topic=topic).replace("{topic}", topic)
+                agent_name = sanitize_agent_name_for_autogen_v4(agent_name)
                 backstory = details['backstory'].format(topic=topic)
 
                 # Convert tools for v0.4 - simplified tool passing