refactor: simplify redundant hasattr checks and fix test formatting

- Remove redundant hasattr checks in agent.py as getattr handles missing attributes
- Fix unnecessary f-string prefixes in test file
- Remove unused variable assignment in test

Co-authored-by: Mervin Praison <[email protected]>

Author: github-actions[bot]

src/praisonai-agents/praisonaiagents/agent/agent.py

@@ -1945,9 +1945,9 @@ async def aexecute(self, task, context=None):
         else:
             prompt = str(task)
         # Extract task info if available
-        task_name = getattr(task, 'name', None) if hasattr(task, 'name') else None
-        task_description = getattr(task, 'description', None) if hasattr(task, 'description') else None
-        task_id = getattr(task, 'id', None) if hasattr(task, 'id') else None
+        task_name = getattr(task, 'name', None)
+        task_description = getattr(task, 'description', None)
+        task_id = getattr(task, 'id', None)
         return await self.achat(prompt, task_name=task_name, task_description=task_description, task_id=task_id)
 
     async def execute_tool_async(self, function_name: str, arguments: Dict[str, Any]) -> Any:

test_task_name_fix.py

@@ -39,7 +39,7 @@ def test_achat_signature():
             print(f"  ❌ Missing parameters: {missing_params}")
             return False
         else:
-            print(f"  ✅ All required parameters present")
+            print("  ✅ All required parameters present")
             return True
 
     except Exception as e:
@@ -76,7 +76,7 @@ def test_task_structure():
         has_id = hasattr(task, 'id')
 
         if has_name and has_description and has_id:
-            print(f"  ✅ Task has all required attributes")
+            print("  ✅ Task has all required attributes")
             return True
         else:
             print(f"  ❌ Task missing attributes - name: {has_name}, description: {has_description}, id: {has_id}")
@@ -104,13 +104,13 @@ async def test_achat_call():
         # This should not raise a NameError for task_name anymore
         try:
             # We expect this to fail due to mock LLM, but NOT due to NameError: task_name not defined
-            response = await agent.achat(
+            await agent.achat(
                 "Test prompt",
                 task_name="test_task",
                 task_description="Test description", 
                 task_id="test_id"
             )
-            print(f"  ✅ achat call succeeded (unexpected but good!)")
+            print("  ✅ achat call succeeded (unexpected but good!)")
             return True
         except NameError as e:
             if "task_name" in str(e):