Merge pull request #952 from MervinPraison/claude/issue-947-20250716-1205

fix: resolve task_name undefined error in LLM callback execution

Author: MervinPraison

src/praisonai-agents/praisonaiagents/llm/llm.py

@@ -894,7 +894,13 @@ def get_response(
                                 message=original_prompt,
                                 response=response_content,
                                 markdown=markdown,
-                                generation_time=generation_time_val
+                                generation_time=generation_time_val,
+                                agent_name=agent_name,
+                                agent_role=agent_role,
+                                agent_tools=agent_tools,
+                                task_name=task_name,
+                                task_description=task_description,
+                                task_id=task_id
                             )
                             callback_executed = True
 
@@ -963,7 +969,13 @@ def get_response(
                                     message=original_prompt,
                                     response=response_text,
                                     markdown=markdown,
-                                    generation_time=time.time() - current_time
+                                    generation_time=time.time() - current_time,
+                                    agent_name=agent_name,
+                                    agent_role=agent_role,
+                                    agent_tools=agent_tools,
+                                    task_name=task_name,
+                                    task_description=task_description,
+                                    task_id=task_id
                                 )
                                 callback_executed = True
 
@@ -1017,7 +1029,13 @@ def get_response(
                                     message=original_prompt,
                                     response=response_text,
                                     markdown=markdown,
-                                    generation_time=time.time() - current_time
+                                    generation_time=time.time() - current_time,
+                                    agent_name=agent_name,
+                                    agent_role=agent_role,
+                                    agent_tools=agent_tools,
+                                    task_name=task_name,
+                                    task_description=task_description,
+                                    task_id=task_id
                                 )
                                 callback_executed = True
 
@@ -1175,7 +1193,13 @@ def get_response(
                     message=original_prompt,
                     response=response_content,
                     markdown=markdown,
-                    generation_time=generation_time_val
+                    generation_time=generation_time_val,
+                    agent_name=agent_name,
+                    agent_role=agent_role,
+                    agent_tools=agent_tools,
+                    task_name=task_name,
+                    task_description=task_description,
+                    task_id=task_id
                 )
                 callback_executed = True
 
@@ -1204,7 +1228,13 @@ def get_response(
                         message=original_prompt,
                         response=response_text,
                         markdown=markdown,
-                        generation_time=time.time() - start_time
+                        generation_time=time.time() - start_time,
+                        agent_name=agent_name,
+                        agent_role=agent_role,
+                        agent_tools=agent_tools,
+                        task_name=task_name,
+                        task_description=task_description,
+                        task_id=task_id
                     )
                     callback_executed = True
                 return response_text
@@ -1224,7 +1254,13 @@ def get_response(
                         message=original_prompt,
                         response=response_text,
                         markdown=markdown,
-                        generation_time=time.time() - start_time
+                        generation_time=time.time() - start_time,
+                        agent_name=agent_name,
+                        agent_role=agent_role,
+                        agent_tools=agent_tools,
+                        task_name=task_name,
+                        task_description=task_description,
+                        task_id=task_id
                     )
                     callback_executed = True
 

test_fix_verification.py

@@ -0,0 +1,72 @@
+#!/usr/bin/env python3
+"""Test the issue fix with a simple callback that expects task_name."""
+
+import asyncio
+from praisonaiagents import Agent, Task, PraisonAIAgents
+
+# Simple callback that expects task_name - this would trigger the error before the fix
+def test_callback(**kwargs):
+    print(f"Callback called with task_name: {kwargs.get('task_name', 'NOT PROVIDED')}")
+    # This would cause the "name 'task_name' is not defined" error before the fix
+    # because the callback functions would try to access task_name but it wasn't passed
+
+# Register the callback
+from praisonaiagents.main import register_display_callback
+register_display_callback('interaction', test_callback)
+
+# Example tool
+def simple_tool():
+    return "Simple tool result"
+
+# Simple agent setup
+test_agent = Agent(
+    name="TestAgent",
+    role="Test Agent",
+    goal="Test the fix",
+    tools=[simple_tool],
+    llm="gpt-4o-mini",  # Using OpenAI for testing
+    verbose=False  # This is key - verbose=False triggers the bug
+)
+
+# Simple task
+test_task = Task(
+    name="test_task",
+    description="Test task for the fix",
+    expected_output="Test output",
+    agent=test_agent
+)
+
+async def main():
+    print("Testing the fix...")
+    
+    # This should work without the "name 'task_name' is not defined" error
+    workflow = PraisonAIAgents(
+        agents=[test_agent],
+        tasks=[test_task],
+        process="sequential",
+        verbose=False  # This should not cause the error anymore
+    )
+    
+    try:
+        await workflow.astart()
+        print("✅ Test passed! No 'task_name' error occurred.")
+        return True
+    except NameError as e:
+        if "task_name" in str(e):
+            print(f"❌ Test failed! Still getting task_name error: {e}")
+            return False
+        else:
+            print(f"❌ Test failed with different error: {e}")
+            return False
+    except Exception as e:
+        print(f"⚠️ Test failed with other error (expected without API key): {e}")
+        # This is expected without API key, but we shouldn't get task_name error
+        if "task_name" in str(e):
+            print("❌ But the task_name error is still present!")
+            return False
+        else:
+            print("✅ No task_name error found, fix appears to work!")
+            return True
+
+if __name__ == "__main__":
+    asyncio.run(main())

test_issue_947.py

@@ -0,0 +1,107 @@
+# agentic_parallelization_varied_tasks.py
+
+import asyncio
+from praisonaiagents import Agent, Task, PraisonAIAgents
+
+# Example tools (replace with real implementations as needed)
+def fetch_favorite_article():
+    # Simulate fetching your favorite morning article
+    return "Your favorite morning article: 'How to Start Your Day Right'"
+
+def search_trending_kenya():
+    # Simulate searching for trending news in Kenya
+    return "Trending in Kenya: 'Kenya launches new tech hub in Nairobi'"
+
+def fetch_twitter_feed():
+    # Simulate fetching Twitter feed
+    return "Latest tweet: 'AI is transforming the world!'"
+
+# Agents for each unique task
+article_agent = Agent(
+    name="ArticleAgent",
+    role="Morning Article Fetcher",
+    goal="Fetch the user's favorite morning article",
+    tools=[fetch_favorite_article],
+    llm="gemini/gemini-2.5-flash-lite-preview-06-17",
+    verbose=True
+)
+
+news_agent = Agent(
+    name="KenyaNewsAgent",
+    role="Kenya News Searcher",
+    goal="Search for trending news in Kenya",
+    tools=[search_trending_kenya],
+    llm="gemini/gemini-2.5-flash-lite-preview-06-17",
+    verbose=True
+)
+
+twitter_agent = Agent(
+    name="TwitterAgent",
+    role="Twitter Feed Fetcher",
+    goal="Fetch the latest Twitter feed",
+    tools=[fetch_twitter_feed],
+    llm="gemini/gemini-2.5-flash-lite-preview-06-17",
+    verbose=True
+)
+
+aggregator = Agent(
+    name="Aggregator",
+    role="Result Aggregator",
+    goal="Aggregate and summarize all results",
+    llm="gemini/gemini-2.5-flash-lite-preview-06-17",
+    verbose=True
+)
+
+# Tasks for each agent
+article_task = Task(
+    name="fetch_article",
+    description="Fetch the user's favorite morning article.",
+    expected_output="The favorite morning article.",
+    agent=article_agent,
+    is_start=True,
+    async_execution=True
+)
+
+news_task = Task(
+    name="search_kenya_news",
+    description="Search for trending news in Kenya.",
+    expected_output="Trending news in Kenya.",
+    agent=news_agent,
+    is_start=True,
+    async_execution=True
+)
+
+twitter_task = Task(
+    name="fetch_twitter",
+    description="Fetch the latest Twitter feed.",
+    expected_output="Latest Twitter feed.",
+    agent=twitter_agent,
+    is_start=True,
+    async_execution=True
+)
+
+# Aggregator task that depends on the above tasks
+aggregate_task = Task(
+    name="aggregate_results",
+    description="Summarize the article, news, and Twitter feed results.",
+    expected_output="A summary of all fetched information.",
+    agent=aggregator,
+    context=[article_task, news_task, twitter_task]
+)
+
+async def main():
+    workflow = PraisonAIAgents(
+        agents=[article_agent, news_agent, twitter_agent, aggregator],
+        tasks=[article_task, news_task, twitter_task, aggregate_task],
+        process="workflow",
+        verbose=True
+    )
+    results = await workflow.astart()
+
+    print("\nParallel Processing Results:")
+    for task_id, result in results["task_results"].items():
+        if result:
+            print(f"Task {task_id}: {result.raw}")
+
+if __name__ == "__main__":
+    asyncio.run(main())

test_simple_fix.py

@@ -0,0 +1,56 @@
+#!/usr/bin/env python3
+"""Simple test for the task_name fix."""
+
+import sys
+from praisonaiagents.main import execute_sync_callback
+
+# Test that execute_sync_callback can handle missing task_name gracefully
+def test_callback(message, response, **kwargs):
+    task_name = kwargs.get('task_name', 'NOT PROVIDED')
+    print(f"Callback received task_name: {task_name}")
+    return True
+
+# Register the callback
+from praisonaiagents.main import register_display_callback
+register_display_callback('interaction', test_callback)
+
+def main():
+    print("Testing execute_sync_callback with missing task_name...")
+    
+    # Test the old way (without task_name) - this should work now
+    try:
+        execute_sync_callback(
+            'interaction',
+            message="test message",
+            response="test response",
+            markdown=True,
+            generation_time=1.0
+        )
+        print("✅ Old-style callback works (task_name defaults to None)")
+    except Exception as e:
+        print(f"❌ Old-style callback failed: {e}")
+        return False
+    
+    # Test the new way (with task_name) - this should also work
+    try:
+        execute_sync_callback(
+            'interaction',
+            message="test message",
+            response="test response",
+            markdown=True,
+            generation_time=1.0,
+            task_name="test_task",
+            task_description="test description",
+            task_id="test_id"
+        )
+        print("✅ New-style callback works (task_name provided)")
+    except Exception as e:
+        print(f"❌ New-style callback failed: {e}")
+        return False
+    
+    print("✅ All tests passed! The fix is working correctly.")
+    return True
+
+if __name__ == "__main__":
+    success = main()
+    sys.exit(0 if success else 1)