Fix memory search extraction and retrieve fallbacks (#1318)

Author: MervinPraison

src/praisonai-agents/praisonaiagents/agent/agent.py

@@ -4025,17 +4025,28 @@ def _get_knowledge_context(self, query: str, use_rag: bool = False) -> tuple:
                 return "", None
 
             # Normalize results format (filter out None values, handle None metadata)
-            if isinstance(search_results, dict) and 'results' in search_results:
+            # Normalize results format (filter out None values, handle None metadata)
+            if hasattr(search_results, "results") and isinstance(getattr(search_results, "results"), list):
+                search_results = getattr(search_results, "results")
+            elif isinstance(search_results, dict) and 'results' in search_results:
+                search_results = search_results['results']
+                
+            if isinstance(search_results, list):
                 results = []
-                for r in search_results['results']:
+                for r in search_results:
                     if r is None:
                         continue
-                    text = r.get('memory', '') or ''
-                    metadata = r.get('metadata') or {}  # Handle None metadata
+                    if isinstance(r, dict):
+                        text = r.get('memory', '') or r.get('text', '') or ''
+                        metadata = r.get('metadata') or {}
+                    else:
+                        text = getattr(r, 'text', None) or getattr(r, 'memory', None) or ''
+                        metadata = getattr(r, 'metadata', None)
+                        if metadata is None:
+                            metadata = {}
+                    
                     if text:
-                        results.append({"text": text, "metadata": metadata})
-            elif isinstance(search_results, list):
-                results = [{"text": str(r), "metadata": {}} for r in search_results if r is not None and str(r)]
+                        results.append({"text": str(text), "metadata": metadata})
             else:
                 results = [{"text": str(search_results), "metadata": {}}] if search_results else []
 

src/praisonai-agents/praisonaiagents/knowledge/adapters/__init__.py

@@ -4,15 +4,42 @@
 Provides adapter implementations for various knowledge backends.
 All adapters implement KnowledgeStoreProtocol.
 
-Adapters are lazy-loaded to avoid importing heavy dependencies.
+Adapters are now registered via the adapter registry to enable
+protocol-driven knowledge backend resolution.
 """
 
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from .mem0_adapter import Mem0Adapter
 
-# Lazy loading for adapters
+# Import registry functions
+from .registry import (
+    register_knowledge_adapter,
+    register_knowledge_factory,
+    get_knowledge_adapter,
+    list_knowledge_adapters,
+    get_first_available_knowledge_adapter,
+    has_knowledge_adapter,
+)
+
+# Import factory functions for heavy adapters
+from .factories import (
+    create_mem0_knowledge_adapter,
+    create_mongodb_knowledge_adapter,
+    create_chroma_knowledge_adapter,
+    create_sqlite_knowledge_adapter,
+)
+
+# Register core adapter factories (lightweight, no heavy dependencies)
+register_knowledge_factory("sqlite", create_sqlite_knowledge_adapter)
+
+# Register heavy adapter factories (lazy-loaded via factories)
+register_knowledge_factory("mem0", create_mem0_knowledge_adapter)
+register_knowledge_factory("mongodb", create_mongodb_knowledge_adapter)
+register_knowledge_factory("chroma", create_chroma_knowledge_adapter)
+
+# Lazy loading for adapters (backward compatibility)
 _LAZY_IMPORTS = {
     "Mem0Adapter": ("praisonaiagents.knowledge.adapters.mem0_adapter", "Mem0Adapter"),
     "MongoDBKnowledgeAdapter": ("praisonaiagents.knowledge.adapters.mongodb_adapter", "MongoDBKnowledgeAdapter"),
@@ -31,10 +58,24 @@ def __getattr__(name: str):
 
 def __dir__():
     """List available attributes."""
-    return list(_LAZY_IMPORTS.keys())
+    return list(_LAZY_IMPORTS.keys()) + [
+        "register_knowledge_adapter",
+        "register_knowledge_factory", 
+        "get_knowledge_adapter",
+        "list_knowledge_adapters",
+        "get_first_available_knowledge_adapter",
+        "has_knowledge_adapter",
+    ]
 
 
 __all__ = [
     "Mem0Adapter",
     "MongoDBKnowledgeAdapter",
+    # Registry functions
+    "register_knowledge_adapter",
+    "register_knowledge_factory",
+    "get_knowledge_adapter", 
+    "list_knowledge_adapters",
+    "get_first_available_knowledge_adapter",
+    "has_knowledge_adapter",
 ]