Try again.

Author: adalisk-emikhaylov

source/MRMesh/MRVector2.h

@@ -130,49 +130,49 @@ struct Vector2
 
 
     /// squared distance between two points, which is faster to compute than just distance
-    [[nodiscard]] T distanceSq( const Vector2& a, const Vector2& b )
+    [[nodiscard]] friend T distanceSq( const Vector2& a, const Vector2& b )
     {
         return ( a - b ).lengthSq();
     }
 
     /// distance between two points, better use distanceSq for higher performance
-    [[nodiscard]] T distance( const Vector2& a, const Vector2& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point<T> )
+    [[nodiscard]] friend T distance( const Vector2& a, const Vector2& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point<T> )
     {
         return ( a - b ).length();
     }
 
     /// cross product
-    [[nodiscard]] T cross( const Vector2& a, const Vector2& b )
+    [[nodiscard]] friend T cross( const Vector2& a, const Vector2& b )
     {
         return a.x * b.y - a.y * b.x;
     }
 
     /// dot product
-    [[nodiscard]] auto dot( const Vector2& a, const Vector2& b ) -> decltype( a.x * b.x )
+    [[nodiscard]] friend auto dot( const Vector2& a, const Vector2& b ) -> decltype( a.x * b.x )
     {
         return a.x * b.x + a.y * b.y;
     }
 
     /// squared length
-    [[nodiscard]] T sqr( const Vector2& a )
+    [[nodiscard]] friend T sqr( const Vector2& a )
     {
         return a.lengthSq();
     }
 
     /// per component multiplication
-    [[nodiscard]] Vector2 mult( const Vector2& a, const Vector2& b )
+    [[nodiscard]] friend Vector2 mult( const Vector2& a, const Vector2& b )
     {
         return { a.x * b.x,a.y * b.y };
     }
 
     /// per component division
-    [[nodiscard]] Vector2 div( const Vector2& a, const Vector2& b )
+    [[nodiscard]] friend Vector2 div( const Vector2& a, const Vector2& b )
     {
         return { a.x / b.x, a.y / b.y };
     }
 
     /// angle in radians between two vectors
-    [[nodiscard]] T angle( const Vector2& a, const Vector2& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point<T> )
+    [[nodiscard]] friend T angle( const Vector2& a, const Vector2& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point<T> )
     {
         return std::atan2( std::abs( cross( a, b ) ), dot( a, b ) );
         // this version is slower and less precise

source/MRMesh/MRVector4.h

@@ -124,37 +124,37 @@ struct Vector4
 
 
     /// squared distance between two points, which is faster to compute than just distance
-    [[nodiscard]] T distanceSq( const Vector4& a, const Vector4& b )
+    [[nodiscard]] friend T distanceSq( const Vector4& a, const Vector4& b )
     {
         return ( a - b ).lengthSq();
     }
 
     /// distance between two points, better use distanceSq for higher performance
-    [[nodiscard]] T distance( const Vector4& a, const Vector4& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point )
+    [[nodiscard]] friend T distance( const Vector4& a, const Vector4& b ) MR_REQUIRES_IF_SUPPORTED( std::floating_point )
     {
         return ( a - b ).length();
     }
 
     /// dot product
-    [[nodiscard]] auto dot( const Vector4& a, const Vector4& b ) -> decltype( a.x * b.x )
+    [[nodiscard]] friend auto dot( const Vector4& a, const Vector4& b ) -> decltype( a.x * b.x )
     {
         return a.x * b.x + a.y * b.y + a.z * b.z + a.w * b.w;
     }
 
     /// squared length
-    [[nodiscard]] T sqr( const Vector4& a )
+    [[nodiscard]] friend T sqr( const Vector4& a )
     {
         return a.lengthSq();
     }
 
     /// per component multiplication
-    [[nodiscard]] Vector4 mult( const Vector4& a, const Vector4& b )
+    [[nodiscard]] friend Vector4 mult( const Vector4& a, const Vector4& b )
     {
         return { a.x * b.x, a.y * b.y, a.z * b.z, a.w * b.w };
     }
 
     /// per component division
-    [[nodiscard]] Vector4 div( const Vector4& a, const Vector4& b )
+    [[nodiscard]] friend Vector4 div( const Vector4& a, const Vector4& b )
     {
         return { a.x / b.x, a.y / b.y, a.z / b.z, a.w / b.w };
     }