CR Fix

Author: Grantim

source/MRMesh/MRAlignContoursToMesh.cpp

@@ -118,6 +118,12 @@ Expected<Mesh> bendContoursAlongCurve( const Contours2f& contours, const CurveFu
     if ( !bbox.valid() )
         return unexpected( "Contours mesh is empty" );
 
+    if ( curve.totalLength <= 0.0f )
+    {
+        assert( !"invalid curve length" );
+        return unexpected( "Invalid curve length" );
+    }
+
     const float cStartDepth = bbox.diagonal() * 0.05f; // use relative depth to avoid floating errors
     addBaseToPlanarMesh( contoursMesh, -cStartDepth );
     contoursMesh.invalidateCaches();
@@ -146,7 +152,7 @@ Expected<Mesh> bendContoursAlongCurve( const Contours2f& contours, const CurveFu
 
         float curveTime = startCurvePos + xInBox;
         if ( params.periodicCurve )
-            curveTime = std::fmodf( curveTime, curve.totalLength );
+            curveTime = curveTime - std::floor( curveTime / curve.totalLength ) * curve.totalLength;
         const auto pos = curve.func( curveTime );
 
         const auto vecx = pos.dir;

source/MRMesh/MRAlignContoursToMesh.h

@@ -71,7 +71,7 @@ MRMESH_API Expected<Mesh> bendContoursAlongSurfacePath( const Contours2f& contou
 
 /// given a polyline by its vertices, computes partial lengths along the polyline from the initial point;
 /// return an error if the polyline is less than 2 points or all points have exactly the same location
-/// \param outCurveLen optional output of the total polyline length (before possible normalization)
+/// \param outCurveLen optional output of the total polyline length
 MRMESH_API Expected<std::vector<float>> findPartialLens( const CurvePoints& cp, float * outCurveLen = nullptr );
 
 /// given a polyline by its vertices, and partial lengths as computed by \ref findPartialLens,
@@ -81,7 +81,7 @@ MRMESH_API Expected<std::vector<float>> findPartialLens( const CurvePoints& cp,
 
 /// given a polyline by its vertices, returns curve function representing it;
 /// return an error if the polyline is less than 2 points or all points have exactly the same location
-/// \param outCurveLen optional output of the total polyline length (before possible normalization)
+/// \param outCurveLen optional output of the total polyline length
 MRMESH_API Expected<CurveFunc> curveFromPoints( const CurvePoints& cp, float * outCurveLen = nullptr );
 MRMESH_API Expected<CurveFunc> curveFromPoints( CurvePoints&& cp, float* outCurveLen = nullptr );