LineObject::setPoints (#5837)

Author: Fedr

source/MRMesh/MRLineObject.cpp

@@ -29,7 +29,7 @@ void LineObject::setDirection( const Vector3f& normal, ViewportId id /*= {}*/ )
 {
     auto currentXf = xf( id );
     currentXf.A = Matrix3f::rotation( Vector3f::plusX(), normal ) * s_.get( id );
-    setXf( currentXf );
+    setXf( currentXf, id );
 }
 
 void LineObject::setCenter( const Vector3f& center, ViewportId id /*= {}*/ )
@@ -46,6 +46,14 @@ void LineObject::setLength( float size, ViewportId id /*= {}*/ )
     setXf( currentXf, id );
 }
 
+void LineObject::setPoints( const Vector3f& a, const Vector3f& b, ViewportId id /*= {}*/ )
+{
+    auto currentXf = xf( id );
+    currentXf.A = Matrix3f::rotation( Vector3f::plusX(), b - a ) * Matrix3f::scale( Vector3f::diagonal( ( b - a ).length() / baseLineObjectLength_ ) );
+    currentXf.b = ( a + b ) * 0.5f;
+    setXf( currentXf, id );
+}
+
 float LineObject::getLength( ViewportId id /*= {}*/ ) const
 {
     return s_.get( id ).x.x * baseLineObjectLength_;

source/MRMesh/MRLineObject.h

@@ -38,30 +38,34 @@ class MRMESH_CLASS LineObject : public FeatureObject
 
     /// calculates direction from xf
     MRMESH_API Vector3f getDirection( ViewportId id = {} ) const;
+
     /// calculates center from xf
     MRMESH_API Vector3f getCenter( ViewportId id = {} ) const;
+
     /// updates xf to fit given normal
     MRMESH_API void setDirection( const Vector3f& normal, ViewportId id = {} );
+
     /// updates xf to fit given center
     MRMESH_API void setCenter( const Vector3f& center, ViewportId id = {} );
+
     /// updates xf to scale size
     MRMESH_API void setLength( float size, ViewportId id = {} );
+
+    /// updates xf for line visually to go from point a to point b
+    MRMESH_API void setPoints( const Vector3f& a, const Vector3f& b, ViewportId id = {} );
+
     /// calculates line size from xf
     [[nodiscard]] MRMESH_API float getLength( ViewportId id = {} ) const;
+
     // Returns point considered as base for the feature
     [[nodiscard]] MRMESH_API virtual Vector3f getBasePoint( ViewportId id = {} ) const override;
 
     /// Returns the starting point, aka `center - dir * len/2`.
     [[nodiscard]] MRMESH_API Vector3f getPointA( ViewportId id = {} ) const;
+
     /// Returns the finishing point, aka `center + dir * len/2`.
     [[nodiscard]] MRMESH_API Vector3f getPointB( ViewportId id = {} ) const;
 
-    [[deprecated( "This confusingly sets half-length. Use `setLength(halfLen * 2)` instead." )]]
-    MR_BIND_IGNORE void setSize( float halfLen, ViewportId id = {} )
-    {
-        setLength( halfLen * 2 , id );
-    }
-
     [[nodiscard]] MRMESH_API FeatureObjectProjectPointResult projectPoint( const Vector3f& point, ViewportId id = {} ) const override;
 
     MRMESH_API virtual const std::vector<FeatureObjectSharedProperty>& getAllSharedProperties() const override;