Enhance DRep registration logic and wallet type detection

- Improved error handling in the registerDRep function to accommodate both multisig and legacy wallets.
- Refactored DRep ID and script retrieval to ensure proper handling of wallet types.
- Updated comments for clarity on wallet type distinctions and script handling.
- Enhanced address building logic to support external stake credential hashes for legacy wallets.

Author: QSchlegel

src/components/pages/wallet/governance/drep/registerDrep.tsx

@@ -114,21 +114,47 @@ export default function RegisterDRep({ onClose }: RegisterDRepProps = {}) {
   }
 
   async function registerDrep(): Promise<void> {
-    if (!connected || !userAddress || !multisigWallet || !appWallet)
-      throw new Error("Multisig wallet not connected");
+    if (!connected || !userAddress || !appWallet)
+      throw new Error("Wallet not connected");
 
     setLoading(true);
     const txBuilder = getTxBuilder(network);
 
-    const drepData = multisigWallet?.getDRep(appWallet);
-    if (!drepData) {
-      throw new Error("DRep not found");
+    // For legacy wallets (no multisigWallet), use appWallet values directly (preserves input order)
+    // For SDK wallets, use multisigWallet to compute DRep ID and script
+    let dRepId: string;
+    let drepCbor: string;
+    let scriptCbor: string;
+    let changeAddress: string;
+    
+    if (multisigWallet) {
+      const drepData = multisigWallet.getDRep(appWallet);
+      if (!drepData) {
+        throw new Error("DRep not found");
+      }
+      dRepId = drepData.dRepId;
+      drepCbor = drepData.drepCbor;
+      const multisigScript = multisigWallet.getScript();
+      const multisigScriptCbor = multisigScript.scriptCbor;
+      const appScriptCbor = appWallet.scriptCbor;
+      if (!multisigScriptCbor && !appScriptCbor) {
+        throw new Error("Script CBOR not found");
+      }
+      scriptCbor = multisigWallet.getKeysByRole(3) ? (multisigScriptCbor || appScriptCbor!) : (appScriptCbor || multisigScriptCbor!);
+      changeAddress = multisigScript.address;
+    } else {
+      // Legacy wallet: use appWallet values (computed with input order preserved)
+      if (!appWallet.dRepId || !appWallet.scriptCbor) {
+        throw new Error("DRep ID or script not found for legacy wallet");
+      }
+      dRepId = appWallet.dRepId;
+      drepCbor = appWallet.scriptCbor; // Use payment script CBOR for legacy wallets
+      scriptCbor = appWallet.scriptCbor;
+      changeAddress = appWallet.address;
     }
-    const { dRepId, drepCbor } = drepData;
 
-    const scriptCbor = multisigWallet?.getKeysByRole(3) ? multisigWallet?.getScript().scriptCbor : appWallet.scriptCbor;
-    if (!scriptCbor) {
-      throw new Error("Script not found");
+    if (!scriptCbor || !changeAddress) {
+      throw new Error("Script or change address not found");
     }
     try {
       const { anchorUrl, anchorHash } = await createAnchor();
@@ -157,7 +183,7 @@ export default function RegisterDRep({ onClose }: RegisterDRepProps = {}) {
           anchorDataHash: anchorHash,
         })
         .certificateScript(drepCbor)
-        .changeAddress(multisigWallet.getScript().address);
+        .changeAddress(changeAddress);
 
 
 

src/utils/common.ts

@@ -27,10 +27,11 @@ export type WalletType = 'legacy' | 'sdk' | 'summon';
 export function getWalletType(wallet: DbWalletWithLegacy): WalletType {
   if (wallet.rawImportBodies?.multisig) return 'summon';
 
-  // Legacy: no stake keys, no stake credential hash, no DRep keys
+  // Legacy: only payment keys (no stake keys, no DRep keys)
+  // External stake credential hash doesn't make it SDK - it's still legacy if only payment keys
   const hasStakeKeys = wallet.signersStakeKeys && wallet.signersStakeKeys.length > 0;
   const hasDRepKeys = wallet.signersDRepKeys && wallet.signersDRepKeys.length > 0;
-  if (!hasStakeKeys && !wallet.stakeCredentialHash && !hasDRepKeys) return 'legacy';
+  if (!hasStakeKeys && !hasDRepKeys) return 'legacy';
 
   return 'sdk';
 }
@@ -262,10 +263,11 @@ export function buildWallet(
       nativeScript.required = wallet.numRequiredSigners!;
     }
 
-    // Build address from payment script only (no staking)
+    // Build address from payment script with external stake credential hash if available
+    // Legacy wallets can have external stake key hash but no individual stake keys
     const address = serializeNativeScript(
       nativeScript as NativeScript,
-      undefined, // No stake credential hash for legacy wallets
+      wallet.stakeCredentialHash as undefined | string, // Use external stake credential hash if available
       network,
     ).address;