Fix: Threading issue

Author: Mesharsky

PLUGIN/Database/Functions.cs

@@ -187,15 +187,15 @@ private void LoadPlayerWeaponPreferences(CCSPlayerController player)
         }
     }
 
-    private static void DeleteWeaponPreferencesFromDb(CCSPlayerController player, int teamNum)
+    private static void DeleteWeaponPreferencesFromDb(ulong steamId, int teamNum)
     {
         try
         {
             using var connection = new MySqlConnection(_connectionString);
 
             connection.Execute(
                 "DELETE FROM vip_weapon_preferences WHERE steamid64 = @SteamID AND team_num = @TeamNum",
-                new { player.SteamID, TeamNum = teamNum }
+                new { SteamID = steamId, TeamNum = teamNum }
             );
         }
         catch (Exception ex)
@@ -338,4 +338,4 @@ private static void RecordVipTestUsage(ulong steamId, string playerName)
             new { SteamID = steamId, Name = playerName, Date = currentTime }
         );
     }
-}
+}

PLUGIN/Manager/WeaponMenuManager.cs

@@ -34,7 +34,7 @@ private HookResult OnPlayerConnectFullWeaponMenu(EventPlayerConnectFull @event,
             return HookResult.Continue;
 
         Server.NextFrame(() => {
-            Task.Run(() => LoadPlayerWeaponPreferences(player));
+            LoadPlayerWeaponPreferences(player);
         });
 
         return HookResult.Continue;
@@ -441,8 +441,9 @@ private static void RemoveTeamWeaponSelection(CCSPlayerController player, int te
 
         if (cachedPlayer.WeaponSelections.TryGetValue(teamNum, out _))
         {
+            var steamId = player.SteamID;
             Server.NextFrame(() => {
-                Task.Run(() => DeleteWeaponPreferencesFromDb(player, teamNum));
+                Task.Run(() => DeleteWeaponPreferencesFromDb(steamId, teamNum));
             });
 
             cachedPlayer.WeaponSelections.Remove(teamNum);