Skip to content

Comments from Elva to PR "Fix homol Series" #30

@LiesaSalzer

Description

@LiesaSalzer

Here are some corrections to do in the qfeat.R file:

The indentation is wrong from lines 241-315
cluster_ID does not have quotes on line 246
Whenever you need to copy the format of a data frame (e.g., lines 257-261), you can do this: newDataFrame <- templateDataFrame[0, ]
Make sure you use <- when assigning values to your variables (e.g., see lines 279 and 280)
You can replace lines 279-299 with:
df_i <- row %>% separate_longer_delim(c(colnames(row)[c(2, 4, 5)]), delim = "/")
df_i <- df_i[1:len,]
df_i$toID <- strsplit(row$toID, split = "/")[[1]]%>% as.numeric()
It would also be great if you could:
Homogenize the naming conventions (see https://bookdown.org/content/d1e53ac9-28ce-472f-bc2c-f499f18264a3/names.html)
Homogenize how you quote the variable names (compare for example line 246 vs 314)
Fix the indentation (see https://codehs.gitbooks.io/introcs/content/Programming-with-Karel/how-to-indent-your-code.html for details). This means that, for example, you could replace lines 231-234 with nontarget::plothomol(homol, xlim=FALSE, ylim=FALSE, plotlegend=TRUE)
Please contact me if you have any questions.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions