Skip to content

Commit d46dff9

Browse files
committed
refactor(platform): move "load monaco" to utils
1 parent 4e940f0 commit d46dff9

File tree

14 files changed

+165
-32
lines changed

14 files changed

+165
-32
lines changed

contributes/meta3d-ui-control-codeedit/src/Main.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { getBeforeRenderEventName } from "meta3d-editor-event-utils/src/Main"
55
import { service as editorWholeService } from "meta3d-editor-whole-protocol/src/service/ServiceType"
66
import { eventName as selectInspectorNodeEventName } from "meta3d-action-select-inspector-node-protocol/src/EventType"
77
import { getRestoreEditorValueEventName } from "meta3d-editor-event-utils/src/Main"
8+
import { getMonaco } from "meta3d-monaco-utils"
89

910
let _bindHiddenContainerEvent = (meta3dState: meta3dState, api: api, container: HTMLElement) => {
1011
let { onCustomGlobalEvent3 } = api.nullable.getExn(api.getPackageService<service>(meta3dState, "meta3d-editor-whole-protocol")).event(meta3dState)
@@ -111,7 +112,7 @@ export let getContribute: getContributeMeta3D<uiControlContribute<inputFunc, spe
111112

112113

113114
if (api.nullable.isNullable(editor)) {
114-
let monaco = (globalThis as any)["meta3d_monaco" as any]
115+
let monaco = getMonaco()
115116

116117
editor = monaco.editor.create(container, {
117118
model: monaco.editor.createModel(code, "typescript"),

doc/1.3.0.org

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -737,11 +737,16 @@ TODO update:
737737

738738

739739

740-
* TODO perf(editor): solve "memory will increase when run editor"
740+
# * TODO perf(editor): solve "memory will increase when run editor"
741741

742-
TODO fix: run editor will increase
742+
# # TODO refresh platform
743+
# # TODO components' arrayBuffer
743744

744-
TODO fix: editor loop will increase
745+
746+
747+
# TODO run editor will increase
748+
749+
# TODO editor loop will increase
745750

746751

747752
* TODO perf(editor): optimize editor loading
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
#Start(1708222798236)
2-
#Done(1708222798297)
1+
#Start(1708241723555)
2+
#Done(1708241723599)
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# ninja log v6
2-
0 24 1708222798258013436 src/service/ServiceType.ast 785165cefc5839bb
3-
1 26 1708222798258088442 Meta3dEngineWholeProtocol.cmi 5f7f0af9dc9a4eae
4-
24 34 1708222798270568541 src/service/ServiceType.d c1e4bb8db3eac460
5-
34 61 1708222798296122726 src/service/ServiceType-Meta3dEngineWholeProtocol.cmj 54975c454ef0149
6-
34 61 1708222798296122726 src/service/ServiceType-Meta3dEngineWholeProtocol.cmi 54975c454ef0149
7-
34 61 1708222798296122726 ../es6_global/src/service/ServiceType.bs.js 54975c454ef0149
8-
34 61 1708222798296122726 ../js/src/service/ServiceType.bs.js 54975c454ef0149
2+
0 14 1708241723569719336 src/service/ServiceType.ast 785165cefc5839bb
3+
1 15 1708241723569830790 Meta3dEngineWholeProtocol.cmi 5f7f0af9dc9a4eae
4+
14 23 1708241723578846241 src/service/ServiceType.d c1e4bb8db3eac460
5+
23 43 1708241723598955736 src/service/ServiceType-Meta3dEngineWholeProtocol.cmj d2945c04508d17d8
6+
23 43 1708241723598955736 src/service/ServiceType-Meta3dEngineWholeProtocol.cmi d2945c04508d17d8
7+
23 43 1708241723598955736 ../es6_global/src/service/ServiceType.bs.js d2945c04508d17d8
8+
23 43 1708241723598955736 ../js/src/service/ServiceType.bs.js d2945c04508d17d8

platform/frontend/bsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"meta3d-engine-whole-protocol",
4141
"meta3d-ui-protocol",
4242
"meta3d-event-data-utils",
43-
"meta3d-file-utils"
43+
"meta3d-file-utils",
44+
"meta3d-monaco-utils"
4445
],
4546
"refmt": 3,
4647
"namespace": true,

platform/frontend/src/external_layer/ui/app/assemble_space/components/element_assemble/code_edit/CodeEdit.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,9 @@ let make = (~service: service, ~code, ~getNewCodeFunc) => {
113113

114114
service.react.useEffect1(. () => {
115115
MessageUtils.showCatchedErrorMessage(() => {
116-
switch MonaoUtils.getMonaco()->Meta3dCommonlib.OptionSt.fromNullable {
116+
switch Meta3dMonacoUtils.Main.getMonaco()->Meta3dCommonlib.OptionSt.fromNullable {
117117
| None =>
118-
MonaoUtils.deferLoad()->Js.Promise.then_(
118+
Meta3dMonacoUtils.Main.deferLoad()->Js.Promise.then_(
119119
value => {
120120
value->Js.Promise.resolve
121121
},

platform/frontend/src/external_layer/ui/app/assemble_space/components/element_assemble/run_element_visual/components/RunElementVisual.res

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,18 @@ let make = (~service: AssembleSpaceType.service) => {
125125

126126
service.react.useEffect1(. () => {
127127
MessageUtils.showCatchedErrorMessage(() => {
128-
MonaoUtils.deferLoad()
129-
->Js.Promise.catch(
130-
e => {
131-
service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
132-
},
133-
_,
134-
)
135-
->ignore
128+
switch Meta3dMonacoUtils.Main.getMonaco() {
129+
| None =>
130+
Meta3dMonacoUtils.Main.deferLoad()
131+
->Js.Promise.catch(
132+
e => {
133+
service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
134+
},
135+
_,
136+
)
137+
->ignore
138+
| Some(_) => ()
139+
}
136140
}, 5->Some)
137141

138142
None

platform/frontend/src/external_layer/ui/app/enter_app/components/EnterApp.res

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,18 @@ let make = (~service: FrontendType.service) => {
2424

2525
React.useEffect1(() => {
2626
MessageUtils.showCatchedErrorMessage(() => {
27-
MonaoUtils.deferLoad()
28-
->Js.Promise.catch(
29-
e => {
30-
service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
31-
},
32-
_,
33-
)
34-
->ignore
27+
switch Meta3dMonacoUtils.Main.getMonaco() {
28+
| None =>
29+
Meta3dMonacoUtils.Main.deferLoad()
30+
->Js.Promise.catch(
31+
e => {
32+
service.console.errorWithExn(. e->Error.promiseErrorToExn, None)->Obj.magic
33+
},
34+
_,
35+
)
36+
->ignore
37+
| Some(_) => ()
38+
}
3539
}, 5->Some)
3640

3741
None
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
.DS_Store
2+
.merlin
3+
.idea/
4+
.vscode/
5+
jest_0/
6+
reference/
7+
node_modules/
8+
mine/
9+
dist/
10+
lib/bs/
11+
.bs.js
12+
.gen.tsx
13+
lib/js/
14+
lib/es6_global/
15+
16+
lib/bs/
17+
.bs.js
18+
.gen.tsx
19+
20+
lib/js/
21+
lib/es6_global/test/
22+
lib/es6_global/test/
23+
24+
coverage
25+
26+
dist/
27+
28+
npm-debug
29+
30+
.bsb.lock
31+
32+
yarn.lock
33+
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
.DS_Store
2+
.merlin
3+
.idea/
4+
.vscode/
5+
jest_0/
6+
reference/
7+
node_modules/
8+
mine/
9+
10+
test/
11+
12+
.github/
13+
14+
donate/
15+
16+
lib/bs/
17+
.bs.js
18+
.gen.tsx
19+
20+
lib/js/
21+
lib/es6_global/test/
22+
23+
coverage
24+
25+
dist/
26+
27+
npm-debug
28+
29+
.bsb.lock
30+
31+
yarn.lock
32+

0 commit comments

Comments
 (0)