Skip to content

Commit e3b4012

Browse files
committed
fix: Set CH_VALUES_PATH location
1 parent 7df59dc commit e3b4012

File tree

3 files changed

+117
-100
lines changed

3 files changed

+117
-100
lines changed

deployment/codefresh-test.yaml

Lines changed: 111 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ steps:
145145
type: parallel
146146
stage: build
147147
steps:
148-
cloudharness-flask:
148+
samples-secret:
149149
type: build
150150
stage: build
151151
dockerfile: Dockerfile
@@ -154,21 +154,21 @@ steps:
154154
build_arguments:
155155
- NOCACHE=${{CF_BUILD_ID}}
156156
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
157-
image_name: cloud-harness/cloudharness-flask
158-
title: Cloudharness flask
159-
working_directory: ./infrastructure/common-images/cloudharness-flask
157+
image_name: cloud-harness/samples-secret
158+
title: Samples secret
159+
working_directory: ./applications/samples/tasks/secret
160160
tags:
161-
- '${{CLOUDHARNESS_FLASK_TAG}}'
161+
- '${{SAMPLES_SECRET_TAG}}'
162162
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
163163
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
164164
when:
165165
condition:
166166
any:
167-
buildDoesNotExist: includes('${{CLOUDHARNESS_FLASK_TAG_EXISTS}}', '{{CLOUDHARNESS_FLASK_TAG_EXISTS}}')
167+
buildDoesNotExist: includes('${{SAMPLES_SECRET_TAG_EXISTS}}', '{{SAMPLES_SECRET_TAG_EXISTS}}')
168168
== true
169-
forceNoCache: includes('${{CLOUDHARNESS_FLASK_TAG_FORCE_BUILD}}', '{{CLOUDHARNESS_FLASK_TAG_FORCE_BUILD}}')
169+
forceNoCache: includes('${{SAMPLES_SECRET_TAG_FORCE_BUILD}}', '{{SAMPLES_SECRET_TAG_FORCE_BUILD}}')
170170
== false
171-
jupyterhub:
171+
workflows-extract-download:
172172
type: build
173173
stage: build
174174
dockerfile: Dockerfile
@@ -177,20 +177,20 @@ steps:
177177
build_arguments:
178178
- NOCACHE=${{CF_BUILD_ID}}
179179
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
180-
image_name: cloud-harness/jupyterhub
181-
title: Jupyterhub
182-
working_directory: ./applications/jupyterhub
180+
image_name: cloud-harness/workflows-extract-download
181+
title: Workflows extract download
182+
working_directory: ./applications/workflows/tasks/extract-download
183183
tags:
184-
- '${{JUPYTERHUB_TAG}}'
184+
- '${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG}}'
185185
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
186186
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
187187
when:
188188
condition:
189189
any:
190-
buildDoesNotExist: includes('${{JUPYTERHUB_TAG_EXISTS}}', '{{JUPYTERHUB_TAG_EXISTS}}')
191-
== true
192-
forceNoCache: includes('${{JUPYTERHUB_TAG_FORCE_BUILD}}', '{{JUPYTERHUB_TAG_FORCE_BUILD}}')
193-
== false
190+
buildDoesNotExist: includes('${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_EXISTS}}',
191+
'{{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_EXISTS}}') == true
192+
forceNoCache: includes('${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_FORCE_BUILD}}',
193+
'{{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_FORCE_BUILD}}') == false
194194
workflows-notify-queue:
195195
type: build
196196
stage: build
@@ -214,6 +214,29 @@ steps:
214214
'{{WORKFLOWS_NOTIFY_QUEUE_TAG_EXISTS}}') == true
215215
forceNoCache: includes('${{WORKFLOWS_NOTIFY_QUEUE_TAG_FORCE_BUILD}}',
216216
'{{WORKFLOWS_NOTIFY_QUEUE_TAG_FORCE_BUILD}}') == false
217+
samples-sum:
218+
type: build
219+
stage: build
220+
dockerfile: Dockerfile
221+
registry: '${{CODEFRESH_REGISTRY}}'
222+
buildkit: true
223+
build_arguments:
224+
- NOCACHE=${{CF_BUILD_ID}}
225+
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
226+
image_name: cloud-harness/samples-sum
227+
title: Samples sum
228+
working_directory: ./applications/samples/tasks/sum
229+
tags:
230+
- '${{SAMPLES_SUM_TAG}}'
231+
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
232+
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
233+
when:
234+
condition:
235+
any:
236+
buildDoesNotExist: includes('${{SAMPLES_SUM_TAG_EXISTS}}', '{{SAMPLES_SUM_TAG_EXISTS}}')
237+
== true
238+
forceNoCache: includes('${{SAMPLES_SUM_TAG_FORCE_BUILD}}', '{{SAMPLES_SUM_TAG_FORCE_BUILD}}')
239+
== false
217240
workflows-send-result-event:
218241
type: build
219242
stage: build
@@ -237,7 +260,7 @@ steps:
237260
'{{WORKFLOWS_SEND_RESULT_EVENT_TAG_EXISTS}}') == true
238261
forceNoCache: includes('${{WORKFLOWS_SEND_RESULT_EVENT_TAG_FORCE_BUILD}}',
239262
'{{WORKFLOWS_SEND_RESULT_EVENT_TAG_FORCE_BUILD}}') == false
240-
samples-secret:
263+
cloudharness-flask:
241264
type: build
242265
stage: build
243266
dockerfile: Dockerfile
@@ -246,19 +269,42 @@ steps:
246269
build_arguments:
247270
- NOCACHE=${{CF_BUILD_ID}}
248271
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
249-
image_name: cloud-harness/samples-secret
250-
title: Samples secret
251-
working_directory: ./applications/samples/tasks/secret
272+
image_name: cloud-harness/cloudharness-flask
273+
title: Cloudharness flask
274+
working_directory: ./infrastructure/common-images/cloudharness-flask
252275
tags:
253-
- '${{SAMPLES_SECRET_TAG}}'
276+
- '${{CLOUDHARNESS_FLASK_TAG}}'
254277
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
255278
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
256279
when:
257280
condition:
258281
any:
259-
buildDoesNotExist: includes('${{SAMPLES_SECRET_TAG_EXISTS}}', '{{SAMPLES_SECRET_TAG_EXISTS}}')
282+
buildDoesNotExist: includes('${{CLOUDHARNESS_FLASK_TAG_EXISTS}}', '{{CLOUDHARNESS_FLASK_TAG_EXISTS}}')
260283
== true
261-
forceNoCache: includes('${{SAMPLES_SECRET_TAG_FORCE_BUILD}}', '{{SAMPLES_SECRET_TAG_FORCE_BUILD}}')
284+
forceNoCache: includes('${{CLOUDHARNESS_FLASK_TAG_FORCE_BUILD}}', '{{CLOUDHARNESS_FLASK_TAG_FORCE_BUILD}}')
285+
== false
286+
jupyterhub:
287+
type: build
288+
stage: build
289+
dockerfile: Dockerfile
290+
registry: '${{CODEFRESH_REGISTRY}}'
291+
buildkit: true
292+
build_arguments:
293+
- NOCACHE=${{CF_BUILD_ID}}
294+
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
295+
image_name: cloud-harness/jupyterhub
296+
title: Jupyterhub
297+
working_directory: ./applications/jupyterhub
298+
tags:
299+
- '${{JUPYTERHUB_TAG}}'
300+
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
301+
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
302+
when:
303+
condition:
304+
any:
305+
buildDoesNotExist: includes('${{JUPYTERHUB_TAG_EXISTS}}', '{{JUPYTERHUB_TAG_EXISTS}}')
306+
== true
307+
forceNoCache: includes('${{JUPYTERHUB_TAG_FORCE_BUILD}}', '{{JUPYTERHUB_TAG_FORCE_BUILD}}')
262308
== false
263309
samples-print-file:
264310
type: build
@@ -307,57 +353,57 @@ steps:
307353
== true
308354
forceNoCache: includes('${{TEST_API_TAG_FORCE_BUILD}}', '{{TEST_API_TAG_FORCE_BUILD}}')
309355
== false
310-
workflows-extract-download:
356+
title: Build parallel step 2
357+
build_application_images_2:
358+
type: parallel
359+
stage: build
360+
steps:
361+
workflows:
311362
type: build
312363
stage: build
313364
dockerfile: Dockerfile
314365
registry: '${{CODEFRESH_REGISTRY}}'
315366
buildkit: true
316367
build_arguments:
317368
- NOCACHE=${{CF_BUILD_ID}}
318-
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
319-
image_name: cloud-harness/workflows-extract-download
320-
title: Workflows extract download
321-
working_directory: ./applications/workflows/tasks/extract-download
369+
- CLOUDHARNESS_FLASK=${{REGISTRY}}/cloud-harness/cloudharness-flask:${{CLOUDHARNESS_FLASK_TAG}}
370+
image_name: cloud-harness/workflows
371+
title: Workflows
372+
working_directory: ./applications/workflows/server
322373
tags:
323-
- '${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG}}'
374+
- '${{WORKFLOWS_TAG}}'
324375
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
325376
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
326377
when:
327378
condition:
328379
any:
329-
buildDoesNotExist: includes('${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_EXISTS}}',
330-
'{{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_EXISTS}}') == true
331-
forceNoCache: includes('${{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_FORCE_BUILD}}',
332-
'{{WORKFLOWS_EXTRACT_DOWNLOAD_TAG_FORCE_BUILD}}') == false
333-
samples-sum:
380+
buildDoesNotExist: includes('${{WORKFLOWS_TAG_EXISTS}}', '{{WORKFLOWS_TAG_EXISTS}}')
381+
== true
382+
forceNoCache: includes('${{WORKFLOWS_TAG_FORCE_BUILD}}', '{{WORKFLOWS_TAG_FORCE_BUILD}}')
383+
== false
384+
volumemanager:
334385
type: build
335386
stage: build
336387
dockerfile: Dockerfile
337388
registry: '${{CODEFRESH_REGISTRY}}'
338389
buildkit: true
339390
build_arguments:
340391
- NOCACHE=${{CF_BUILD_ID}}
341-
- CLOUDHARNESS_BASE=${{REGISTRY}}/cloud-harness/cloudharness-base:${{CLOUDHARNESS_BASE_TAG}}
342-
image_name: cloud-harness/samples-sum
343-
title: Samples sum
344-
working_directory: ./applications/samples/tasks/sum
392+
- CLOUDHARNESS_FLASK=${{REGISTRY}}/cloud-harness/cloudharness-flask:${{CLOUDHARNESS_FLASK_TAG}}
393+
image_name: cloud-harness/volumemanager
394+
title: Volumemanager
395+
working_directory: ./applications/volumemanager/server
345396
tags:
346-
- '${{SAMPLES_SUM_TAG}}'
397+
- '${{VOLUMEMANAGER_TAG}}'
347398
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
348399
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
349400
when:
350401
condition:
351402
any:
352-
buildDoesNotExist: includes('${{SAMPLES_SUM_TAG_EXISTS}}', '{{SAMPLES_SUM_TAG_EXISTS}}')
403+
buildDoesNotExist: includes('${{VOLUMEMANAGER_TAG_EXISTS}}', '{{VOLUMEMANAGER_TAG_EXISTS}}')
353404
== true
354-
forceNoCache: includes('${{SAMPLES_SUM_TAG_FORCE_BUILD}}', '{{SAMPLES_SUM_TAG_FORCE_BUILD}}')
405+
forceNoCache: includes('${{VOLUMEMANAGER_TAG_FORCE_BUILD}}', '{{VOLUMEMANAGER_TAG_FORCE_BUILD}}')
355406
== false
356-
title: Build parallel step 2
357-
build_application_images_2:
358-
type: parallel
359-
stage: build
360-
steps:
361407
samples:
362408
type: build
363409
stage: build
@@ -405,52 +451,6 @@ steps:
405451
== true
406452
forceNoCache: includes('${{COMMON_TAG_FORCE_BUILD}}', '{{COMMON_TAG_FORCE_BUILD}}')
407453
== false
408-
workflows:
409-
type: build
410-
stage: build
411-
dockerfile: Dockerfile
412-
registry: '${{CODEFRESH_REGISTRY}}'
413-
buildkit: true
414-
build_arguments:
415-
- NOCACHE=${{CF_BUILD_ID}}
416-
- CLOUDHARNESS_FLASK=${{REGISTRY}}/cloud-harness/cloudharness-flask:${{CLOUDHARNESS_FLASK_TAG}}
417-
image_name: cloud-harness/workflows
418-
title: Workflows
419-
working_directory: ./applications/workflows/server
420-
tags:
421-
- '${{WORKFLOWS_TAG}}'
422-
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
423-
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
424-
when:
425-
condition:
426-
any:
427-
buildDoesNotExist: includes('${{WORKFLOWS_TAG_EXISTS}}', '{{WORKFLOWS_TAG_EXISTS}}')
428-
== true
429-
forceNoCache: includes('${{WORKFLOWS_TAG_FORCE_BUILD}}', '{{WORKFLOWS_TAG_FORCE_BUILD}}')
430-
== false
431-
volumemanager:
432-
type: build
433-
stage: build
434-
dockerfile: Dockerfile
435-
registry: '${{CODEFRESH_REGISTRY}}'
436-
buildkit: true
437-
build_arguments:
438-
- NOCACHE=${{CF_BUILD_ID}}
439-
- CLOUDHARNESS_FLASK=${{REGISTRY}}/cloud-harness/cloudharness-flask:${{CLOUDHARNESS_FLASK_TAG}}
440-
image_name: cloud-harness/volumemanager
441-
title: Volumemanager
442-
working_directory: ./applications/volumemanager/server
443-
tags:
444-
- '${{VOLUMEMANAGER_TAG}}'
445-
- '${{DEPLOYMENT_PUBLISH_TAG}}-dev'
446-
- '${{CF_BRANCH_TAG_NORMALIZED_LOWER_CASE}}'
447-
when:
448-
condition:
449-
any:
450-
buildDoesNotExist: includes('${{VOLUMEMANAGER_TAG_EXISTS}}', '{{VOLUMEMANAGER_TAG_EXISTS}}')
451-
== true
452-
forceNoCache: includes('${{VOLUMEMANAGER_TAG_FORCE_BUILD}}', '{{VOLUMEMANAGER_TAG_FORCE_BUILD}}')
453-
== false
454454
title: Build parallel step 3
455455
tests_unit:
456456
stage: unittest
@@ -485,13 +485,13 @@ steps:
485485
commands:
486486
- kubectl config use-context ${{CLUSTER_NAME}}
487487
- kubectl config set-context --current --namespace=test-${{NAMESPACE_BASENAME}}
488-
- kubectl rollout status deployment/common
489-
- kubectl rollout status deployment/volumemanager
490488
- kubectl rollout status deployment/workflows
491-
- kubectl rollout status deployment/argo-gk
492489
- kubectl rollout status deployment/accounts
490+
- kubectl rollout status deployment/common
493491
- kubectl rollout status deployment/samples
494492
- kubectl rollout status deployment/samples-gk
493+
- kubectl rollout status deployment/argo-gk
494+
- kubectl rollout status deployment/volumemanager
495495
- sleep 60
496496
tests_api:
497497
stage: qa
@@ -511,7 +511,10 @@ steps:
511511
- APP_URL=https://workflows.${{DOMAIN}}/api
512512
- SCHEMATHESIS_HOOKS=cloudharness_test.apitest_init
513513
commands:
514-
- harness-test . -i workflows -a
514+
- echo $CH_VALUES_PATH
515+
- ls -la $CH_VALUES_PATH
516+
- ls -la $CH_VALUES_PATH/deployment
517+
- harness-test $CH_VALUES_PATH -i workflows -a
515518
samples_api_test:
516519
title: samples api test
517520
volumes:
@@ -523,7 +526,10 @@ steps:
523526
- PASSWORD=test
524527
- SCHEMATHESIS_HOOKS=cloudharness_test.apitest_init
525528
commands:
526-
- harness-test . -i samples -a
529+
- echo $CH_VALUES_PATH
530+
- ls -la $CH_VALUES_PATH
531+
- ls -la $CH_VALUES_PATH/deployment
532+
- harness-test $CH_VALUES_PATH -i samples -a
527533
- pytest -v test/api
528534
volumemanager_api_test:
529535
title: volumemanager api test
@@ -536,7 +542,10 @@ steps:
536542
- PASSWORD=test
537543
- SCHEMATHESIS_HOOKS=cloudharness_test.apitest_init
538544
commands:
539-
- harness-test . -i volumemanager -a
545+
- echo $CH_VALUES_PATH
546+
- ls -la $CH_VALUES_PATH
547+
- ls -la $CH_VALUES_PATH/deployment
548+
- harness-test $CH_VALUES_PATH -i volumemanager -a
540549
common_api_test:
541550
title: common api test
542551
volumes:
@@ -546,7 +555,10 @@ steps:
546555
- APP_URL=https://common.${{DOMAIN}}/api
547556
- SCHEMATHESIS_HOOKS=cloudharness_test.apitest_init
548557
commands:
549-
- harness-test . -i common -a
558+
- echo $CH_VALUES_PATH
559+
- ls -la $CH_VALUES_PATH
560+
- ls -la $CH_VALUES_PATH/deployment
561+
- harness-test $CH_VALUES_PATH -i common -a
550562
hooks:
551563
on_fail:
552564
exec:

test/test-api/Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ ARG CLOUDHARNESS_BASE
22

33
FROM $CLOUDHARNESS_BASE
44

5+
ENV CH_VALUES_PATH=/codefresh/volume/cloud-harness
6+
57
# Install cloudharness-utils first (required by other packages)
68
COPY libraries/cloudharness-utils/requirements.txt /libraries/cloudharness-utils/requirements.txt
79
RUN pip install -r /libraries/cloudharness-utils/requirements.txt --no-cache-dir

tools/deployment-cli-tools/ch_cli_tools/codefresh.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,10 @@ def api_tests_commands(app_config: ApplicationHarnessConfig, run_custom_tests, a
462462
if api_config.autotest:
463463
# harness-test requires values.yaml generated & domain; Codefresh sets environment accordingly.
464464
# We limit to the specific app using -i and run only api tests with -a
465-
commands.append(f"harness-test . -i {app_name} -a")
465+
commands.append(f"echo $CH_VALUES_PATH")
466+
commands.append(f"ls -la $CH_VALUES_PATH")
467+
commands.append(f"ls -la $CH_VALUES_PATH/deployment")
468+
commands.append(f"harness-test $CH_VALUES_PATH -i {app_name} -a")
466469
if run_custom_tests:
467470
commands.append("pytest -v test/api")
468471
return commands

0 commit comments

Comments
 (0)