参数为0的逻辑失效问题

Author: glide-the

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "zhipuai"
-version = "2.0.1.20240426"
+version = "2.0.1.20240427"
 description = "A SDK library for accessing big model apis from ZhipuAI"
 authors = ["Zhipu AI"]
 readme = "README.md"

tests/integration_tests/test_chat.py

@@ -4,6 +4,112 @@
 import zhipuai
 
 
+def test_completions_temp0():
+    client = ZhipuAI()  # 填写您自己的APIKey
+    try:
+        response = client.chat.completions.create(
+            model="glm-4",
+            messages=[
+                {
+                    "role": "user",
+                    "content": "tell me a joke"
+                }
+            ],
+            top_p=0.7,
+            temperature=0,
+            max_tokens=2000,
+        )
+        print(response)
+
+    except zhipuai.core._errors.APIRequestFailedError as err:
+        print(err)
+    except zhipuai.core._errors.APIInternalError as err:
+        print(err)
+    except zhipuai.core._errors.APIStatusError as err:
+        print(err)
+
+
+def test_completions_temp1():
+    client = ZhipuAI()  # 填写您自己的APIKey
+    try:
+        response = client.chat.completions.create(
+            model="glm-4",
+            messages=[
+                {
+                    "role": "user",
+                    "content": "tell me a joke"
+                }
+            ],
+            top_p=0.7,
+            temperature=1,
+            max_tokens=2000,
+        )
+        print(response)
+
+
+
+    except zhipuai.core._errors.APIRequestFailedError as err:
+        print(err)
+    except zhipuai.core._errors.APIInternalError as err:
+        print(err)
+    except zhipuai.core._errors.APIStatusError as err:
+        print(err)
+
+
+def test_completions_top0():
+    client = ZhipuAI()  # 填写您自己的APIKey
+    try:
+        response = client.chat.completions.create(
+            model="glm-4",
+            messages=[
+                {
+                    "role": "user",
+                    "content": "tell me a joke"
+                }
+            ],
+            top_p=0,
+            temperature=0.9,
+            max_tokens=2000,
+        )
+        print(response)
+
+
+
+    except zhipuai.core._errors.APIRequestFailedError as err:
+        print(err)
+    except zhipuai.core._errors.APIInternalError as err:
+        print(err)
+    except zhipuai.core._errors.APIStatusError as err:
+        print(err)
+
+
+def test_completions_top1():
+    client = ZhipuAI()  # 填写您自己的APIKey
+    try:
+        response = client.chat.completions.create(
+            model="glm-4",
+            messages=[
+                {
+                    "role": "user",
+                    "content": "tell me a joke"
+                }
+            ],
+            top_p=1,
+            temperature=0.9,
+            max_tokens=2000,
+        )
+        print(response)
+
+
+
+    except zhipuai.core._errors.APIRequestFailedError as err:
+        print(err)
+    except zhipuai.core._errors.APIInternalError as err:
+        print(err)
+    except zhipuai.core._errors.APIStatusError as err:
+        print(err)
+
+
 def test_completions():
     client = ZhipuAI()  # 填写您自己的APIKey
     try:
@@ -38,6 +144,7 @@ def test_completions():
     except zhipuai.core._errors.APIStatusError as err:
         print(err)
 
+
 def test_completions_stream():
     client = ZhipuAI()  # 填写您自己的APIKey
     try:
@@ -64,6 +171,7 @@ def test_completions_stream():
     except zhipuai.core._errors.APIStatusError as err:
         print(err)
 
+
 # Function to encode the image
 def encode_image(image_path):
     import base64
@@ -149,6 +257,7 @@ def test_completions_vis_base64(test_file_path):
     except zhipuai.core._errors.APIStatusError as err:
         print(err)
 
+
 def test_async_completions():
     client = ZhipuAI()  # 请填写您自己的APIKey
     try:
@@ -183,6 +292,7 @@ def test_async_completions():
     except zhipuai.core._errors.APIStatusError as err:
         print(err)
 
+
 def test_retrieve_completion_result():
     client = ZhipuAI()  # 请填写您自己的APIKey
     try:
@@ -196,3 +306,7 @@ def test_retrieve_completion_result():
         print(err)
     except zhipuai.core._errors.APIStatusError as err:
         print(err)
+
+
+if __name__ == '__main__':
+    test_completions_top0()

zhipuai/api_resource/chat/completions.py

@@ -50,7 +50,9 @@ def create(
             _cast_type = object
             _stream_cls = StreamResponse[object]
 
-        if temperature:
+        print(f"temperature:{temperature}")
+        print(f"top_p:{top_p}")
+        if temperature is not None and temperature != NOT_GIVEN:
 
             if temperature <= 0:
                 do_sample = False
@@ -60,7 +62,7 @@ def create(
                 do_sample = False
                 temperature = 0.99
                 logger.warning("取值范围是：(0.0, 1.0) 开区间，do_sample重写为:false（参数top_p temperture不生效）")
-        if top_p:
+        if top_p is not None and top_p != NOT_GIVEN:
 
             if top_p >= 1:
                 top_p = 0.99
@@ -69,6 +71,8 @@ def create(
                 top_p = 0.01
                 logger.warning("取值范围是：(0.0, 1.0) 开区间，不能等于 0 或 1")
 
+        print(f"temperature:{temperature}")
+        print(f"top_p:{top_p}")
         if isinstance(messages, List):
             for item in messages:
                 if item.get('content'):