Refactor controller initialization in tests (#251)

* Refactor controller initialization in tests

Each test now uses a helper function to construct the keyring
controller rather than using `beforeEach`. This eliminates redundant
redundancy in cases where the controller was being overwritten, and
makes it easier for future tests to customize how the controller is
initialized.

* Remove unnecessary submit password step

* Simplify types

Author: Gudahtt