Skip to content

Commit 3fac128

Browse files
authored
fix: fix prepare-preview-builds.ts (#444)
Deps might actually be undefined if some of our packages don't depend on any others (like for the `account-api`). So we need to add fallback records for those cases. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Ensures the preview build script tolerates packages without dependency sections. > > - In `scripts/prepare-preview-builds.ts`, default `dependencies` and `peerDependencies` to `{}` before mutation when moving peer deps to `dependencies` and when pinning workspace versions in `dependencies`/`devDependencies` > - Prevents errors when a package lacks `dependencies`/`peerDependencies` > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d09be21. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 7279322 commit 3fac128

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

scripts/prepare-preview-builds.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ async function updateWorkspacePackagesWithPreviewInfo(
150150
const peerDepKey = 'peerDependencies';
151151
if (peerDepKey in pkgJson.content) {
152152
const depKey = 'dependencies';
153-
const deps = pkgJson.content[depKey] as DependenciesRecord;
154-
const peerDeps = pkgJson.content[peerDepKey] as DependenciesRecord;
153+
const deps: DependenciesRecord = pkgJson.content[depKey] ?? {};
154+
const peerDeps: DependenciesRecord = pkgJson.content[peerDepKey] ?? {};
155155

156156
for (const { name, version } of previewPkgs) {
157157
// Only consider dependenc that refers to a local workspace package
@@ -173,7 +173,7 @@ async function updateWorkspacePackagesWithPreviewInfo(
173173
// of that package instead, and `yarn` will resolve this using the global resolutions
174174
// (see `updateWorkspaceResolutions`)
175175
for (const depKey of ['dependencies', 'devDependencies']) {
176-
const deps = pkgJson.content[depKey] as DependenciesRecord;
176+
const deps: DependenciesRecord = pkgJson.content[depKey] ?? {};
177177

178178
for (const { name, version } of previewPkgs) {
179179
// Only consider dependenc that refers to a local workspace package

0 commit comments

Comments
 (0)