feat(keyring-eth-money): add money account keyring based on hd-key-ring#472
feat(keyring-eth-money): add money account keyring based on hd-key-ring#472
Conversation
5f50434 to
ca5f3e9
Compare
ca5f3e9 to
01e9b64
Compare
Yes, if this is what the product expects, we should enforce it. Otherwise, we might mistakenly create more than one account and end up dealing with this kind of hard-to-solve bug. |
|
Calling it WDYT @gantunesr, @ccharly ? |
I think you're right yep! |
81d726d to
fe35f69
Compare
5395223 to
b26b341
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
left a comment
There was a problem hiding this comment.
LGTM, we'll follow-up with another PR to re-specialize serialize and deserialize so it matches the keyring's semantic even more (see https://github.com/MetaMask/accounts/pull/472/files#r2959166319)
Implements a new keyring to support MUSD-386
Examples
Note
Medium Risk
Introduces a new keyring package and extends the public
KeyringTypeenum, which may affect downstream consumers and account derivation behavior if integrated incorrectly.Overview
Adds a new
@metamask/eth-money-keyringpackage that extends@metamask/eth-hd-keyringwith a dedicated type ("Money Keyring"), a fixed derivation path (m/44'/4392018'/0'/0), and enforced single-account behavior (overriddendeserialize/addAccounts).Updates
@metamask/keyring-apito includeKeyringType.Money(plus type-level tests and changelog), and wires the new package into repo tooling/docs (README module list/graph, roottsconfig.build.json, PR-title scope allowlist, andyarn.lock).Written by Cursor Bugbot for commit 62f41a9. This will update automatically on new commits. Configure here.