Skip to content

Commit 184b340

Browse files
authored
fix: cleanup log when fetching balances (#7429)
## Explanation Cleans up warning log when fetching balances. ## References * Fixes [#12345](MetaMask/metamask-extension#37183) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes warning logs on failed chain balance fetches in `RpcBalanceFetcher` and documents the change in the changelog. > > - **Logging cleanup** > - Remove warning logs for failed chain balance fetches in `packages/assets-controllers/src/rpc-service/rpc-balance-fetcher.ts` (skip rejected results without logging). > - **Changelog** > - Update `packages/assets-controllers/CHANGELOG.md` under “Changed” to note the logging removal. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6c2d0e1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent b66ca79 commit 184b340

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/assets-controllers/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414

1515
### Changed
1616

17+
- Remove warning logs for failed chain balance fetches in RPC balance fetcher ([#7429](https://github.com/MetaMask/core/pull/7429))
1718
- Reduce severity of ERC721 metadata interface log from `console.error` to `console.warn` ([#7412](https://github.com/MetaMask/core/pull/7412))
1819
- Fixes [#24988](https://github.com/MetaMask/metamask-extension/issues/24988)
1920
- Bump `@metamask/transaction-controller` from `^62.4.0` to `^62.6.0` ([#7325](https://github.com/MetaMask/core/pull/7325), [#7430](https://github.com/MetaMask/core/pull/7430))

packages/assets-controllers/src/rpc-service/rpc-balance-fetcher.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,6 @@ export class RpcBalanceFetcher implements BalanceFetcher {
191191
chainResultsArray.forEach((chainResult) => {
192192
if (chainResult.status === 'fulfilled') {
193193
results.push(...chainResult.value);
194-
} else {
195-
// Log error but continue with other chains
196-
console.warn('Chain processing failed:', chainResult.reason);
197194
}
198195
});
199196

0 commit comments

Comments
 (0)