refactor: fix lint

Author: Prithpal-Sooriya

packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.test.ts

@@ -47,7 +47,7 @@ import * as OnChainNotifications from './services/onchain-notifications';
 import type { INotification } from './types';
 import type { UserStorage } from './types/user-storage/user-storage';
 import * as Utils from './utils/utils';
-import { NotificationServicesPushControllerGetStateAction } from '../NotificationServicesPushController';
+import type { NotificationServicesPushControllerGetStateAction } from '../NotificationServicesPushController';
 
 // Mock type used for testing purposes
 // eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts

@@ -307,6 +307,7 @@ export default class NotificationServicesController extends BaseController<
   #isPushNotificationsSetup = false;
 
   #isUnlocked = false;
+
   #keyringController = {
     setupLockedStateSubscriptions: (onUnlock: () => Promise<void>) => {
       const { isUnlocked } = this.messagingSystem.call(
@@ -382,7 +383,6 @@ export default class NotificationServicesController extends BaseController<
             // Push notifications were disabled
             if (prevVal === true && newVal === false) {
               this.#isPushNotificationsSetup = false;
-              return;
             }
           } catch {
             // Do nothing, silently fail push notifications
@@ -565,7 +565,6 @@ export default class NotificationServicesController extends BaseController<
    * @param args.state - Initial state to set on this controller.
    * @param args.env - environment variables for a given controller.
    * @param args.env.featureAnnouncements - env variables for feature announcements.
-   * @param args.env.isPushIntegrated - toggle push notifications on/off if client has integrated them.
    */
   constructor({
     messenger,

packages/notification-services-controller/src/NotificationServicesPushController/NotificationServicesPushController.ts

@@ -8,14 +8,14 @@ import { BaseController } from '@metamask/base-controller';
 import type { AuthenticationController } from '@metamask/profile-sync-controller';
 import log from 'loglevel';
 
-import type { Types } from '../NotificationServicesController';
 import {
   activatePushNotifications,
   deactivatePushNotifications,
   updateTriggerPushNotifications,
 } from './services/services';
 import type { PushNotificationEnv } from './types';
 import type { PushService } from './types/push-service-interface';
+import type { Types } from '../NotificationServicesController';
 
 const controllerName = 'NotificationServicesPushController';
 
@@ -143,8 +143,6 @@ export type ControllerConfig = {
  * It is responsible for registering and unregistering the service worker that listens for push notifications,
  * managing the FCM token, and communicating with the server to register or unregister the device for push notifications.
  * Additionally, it provides functionality to update the server with new UUIDs that should trigger push notifications.
- *
- * @augments {BaseController<typeof controllerName, NotificationServicesPushControllerState, NotificationServicesPushControllerMessenger>}
  */
 export default class NotificationServicesPushController extends BaseController<
   typeof controllerName,
@@ -153,9 +151,9 @@ export default class NotificationServicesPushController extends BaseController<
 > {
   #pushListenerUnsubscribe: (() => void) | undefined = undefined;
 
-  #env: PushNotificationEnv;
+  readonly #env: PushNotificationEnv;
 
-  #config: ControllerConfig;
+  readonly #config: ControllerConfig;
 
   constructor({
     messenger,
@@ -232,7 +230,7 @@ export default class NotificationServicesPushController extends BaseController<
         (await this.#config.pushService.subscribeToPushNotifications(
           this.#env,
         )) ?? undefined;
-    } catch (e) {
+    } catch {
       // Do nothing, we are silently failing if push notification registration fails
     }
   }
@@ -301,11 +299,9 @@ export default class NotificationServicesPushController extends BaseController<
     }
 
     const bearerToken = await this.#getAndAssertBearerToken();
-    let isPushNotificationsDisabled: boolean;
-
     try {
       // Send a request to the server to unregister the token/device
-      isPushNotificationsDisabled = await deactivatePushNotifications({
+      await deactivatePushNotifications({
         bearerToken,
         triggers: UUIDs,
         env: this.#env,